Skip to contentSkip to conversation

Fix a memory overflow bug when copying NULL internal package element object to external.

PATCH Applied Thomas Renninger 2 participants 2 messages Mar 12, 2008 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Fix a memory overflow bug when copying NULL internal package element object to external.

From: Lin Ming <[email protected]>

Fix a memory overflow bug when copying
NULL internal package element object to external.

Tested-by: Thomas Renninger <[email protected]>

---
 drivers/acpi/utilities/utobject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/utilities/utobject.c +1 -1
Index: linux-2.6/drivers/acpi/utilities/utobject.c
===================================================================
@@ -432,7 +432,7 @@ acpi_ut_get_simple_object_size(union acp
 	 * element -- which is legal)
 	 */
 	if (!internal_object) {
-		*obj_length = 0;
+		*obj_length = sizeof(union acpi_object);
 		return_ACPI_STATUS(AE_OK);
 	}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

reviewer
#1 lore raw

this one is already in via bugzilla 10132.

thanks,
-Len

Quoted 22 lines · Thomas Renninger

From: Lin Ming <[email protected]>

Fix a memory overflow bug when copying
NULL internal package element object to external.

Tested-by: Thomas Renninger <[email protected]>

---
 drivers/acpi/utilities/utobject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/acpi/utilities/utobject.c
===================================================================

drivers/acpi/utilities/utobject.c acpi_ut_get_simple_object_size(union acp · line 438

Quoted 8 lines
drivers/acpi/utilities/utobject.c +1 -1
@@ -432,7 +432,7 @@ acpi_ut_get_simple_object_size(union acp
 	 * element -- which is legal)
 	 */
 	if (!internal_object) {
-		*obj_length = 0;
+		*obj_length = sizeof(union acpi_object);
 		return_ACPI_STATUS(AE_OK);
 	}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html