net/ice/base: fix wrong outer ipv6 ptype table
PATCH 1/1 net/ice/base: fix wrong outer ipv6 ptype table
ptype 264, 265, 266, 267, 275 is should not be set in ice_ptypes_ipv6_ofos_all.
--- drivers/net/ice/base/ice_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_flow.c +1 -1
@@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = {static const u32 ice_ptypes_ipv6_ofos_all[] = {0x00000000 ,0x00000000 ,0x77000000 ,0x10002000 ,0x00000000 ,0x000002AA ,0x00000000 ,0x00000000 , -0x00080F00 ,0x03F00000 ,0x7C1F0000 ,0x00000206 , +0x00000000 ,0x03F00000 ,0x7C1F0000 ,0x00000206 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,
Signature · 1 line
2.13.6
Quoted 11 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Qi Zhang
Sent: Sunday, September 6, 2020 9:02 PM
To: Yang, Qiming <[email protected]>
Cc: Xu, Ting <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH]net/ice/base: fix wrong outer ipv6 ptype tableptype 264, 265, 266, 267, 275 is should not be set in
ice_ptypes_ipv6_ofos_all.
A tiny comment, "is" should be deleted, right? And I think ptype name is more readable than number when interpret the reason, you choose. After that patch is ok.
Quoted 23 lines
Fixes 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH")Signed-off-by Qi Zhang <[email protected]>--- drivers/net/ice/base/ice_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/net/ice/base/ice_flow.cindex6035bdfcf..552e58f9b100644drivers/net/ice/base/ice_flow.c +1
-2@@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = { staticconst u32 ice_ptypes_ipv6_ofos_all[] = {0x00000000 ,0x00000000 ,0x77000000 ,0x10002000 ,0x00000000 ,0x000002AA ,0x00000000 ,0x00000000 , -0x00080F00 ,0x03F00000 ,0x7C1F0000 ,0x00000206 , +0x00000000 ,0x03F00000 ,0x7C1F0000 ,0x00000206 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 ,0x00000000 , --2.13.6
Zhang, Qi Z
AppliedQuoted 21 lines
-----Original Message-----
From: Guo, Jia <[email protected]>
Sent: Tuesday, September 8, 2020 11:59 AM
To: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>
Cc: Xu, Ting <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH]net/ice/base: fix wrong outer ipv6 ptype tableQuoted 9 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Qi Zhang
Sent: Sunday, September 6, 2020 9:02 PM
To: Yang, Qiming <[email protected]>
Cc: Xu, Ting <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH]net/ice/base: fix wrong outer ipv6 ptype table
Quoted 5 lines
Quoted 1 line
ptype 264, 265, 266, 267, 275 is should not be set in
ice_ptypes_ipv6_ofos_all.Quoted 1 line
A tiny comment, "is" should be deleted, right?
yes
Quoted 3 lines
And I think ptype name is more
readable than number when interpret the reason, you choose. After that patch is ok.
These ptypes are reserved, they have no name.
Quoted 2 lines
Acked-by Jeff Guo <[email protected]>
Applied to dpdk-next-net-intel after correct the commit log.
Thanks
Qi