media change events - do not emit change event at device add

PATCH New Kay Sievers 1 participant 1 message Mar 19, 2008 SCSI

Share & tools

Kay Sievers

author

2008-03-19 21:10 UTC #0 lore raw

PATCH 1/1 media change events - do not emit change event at device add

Hi James,
we like to see this in 2.6.25. There is no need to send out "change" events immediately after we added a new device. Presetting the state flag prevents this.

Thanks,
Kay

From: Kay Sievers <[email protected]>
Subject: [SCSI] media change events - do not emit change event at device add

Initialize the "state changed" flag, so we do not send a change event immediately after registering a new device.

Signed-off-by Kay Sievers <[email protected]>

---

drivers/scsi/sd.c +1 -0

index 7aee64d..5fe7aae 100644
@@ -1654,6 +1654,7 @@ static int sd_probe(struct device *dev)
 	sdkp->disk = gd;
 	sdkp->index = index;
 	sdkp->openers = 0;
+	sdkp->previous_state = 1;
 
 	if (!sdp->timeout) {
 		if (sdp->type != TYPE_MOD)

drivers/scsi/sr.c +1 -0

index 208565b..7ee86d4 100644
@@ -623,6 +623,7 @@ static int sr_probe(struct device *dev)
 	cd->disk = disk;
 	cd->capacity = 0x1fffff;
 	cd->device->changed = 1;	/* force recheck CD type */
+	cd->previous_state = 1;
 	cd->use = 1;
 	cd->readcd_known = 0;
 	cd->readcd_cdda = 0;