Skip to contentSkip to conversation

Blackfin Video Driver: fix bug when opening/reading/mmaping BF54x and BF52x framebuffer simultaneously

PATCH Applied Bryan Wu 1 participant 1 message Mar 26, 2008 Framebuffer layer

lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 2/2 Blackfin Video Driver: fix bug when opening/reading/mmaping BF54x and BF52x framebuffer simultaneously

From: Michael Hennerich <[email protected]>

http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3974

opening/reading/mmaping BF54x and BF52x framebuffer simultaneously triggers BUG: failure at mm/nommu.c:470/add_nommu_vma() Add VM_SHARED to the default vm_flags

---
 drivers/video/bf54x-lq043fb.c    |    2 +-
 drivers/video/bfin-t350mcqb-fb.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/bf54x-lq043fb.c +1 -1
index 986a550..eefba3d 100644
@@ -384,7 +384,7 @@ static int bfin_bf54x_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	 *   Other flags can be set, and are documented in
 	 *   include/linux/mm.h
 	 */
-	vma->vm_flags |= VM_MAYSHARE;
+	vma->vm_flags |=  VM_MAYSHARE | VM_SHARED;
 
 	return 0;
 }
drivers/video/bfin-t350mcqb-fb.c +1 -1
index 68d5857..c92d457 100644
@@ -302,7 +302,7 @@ static int bfin_t350mcqb_fb_mmap(struct fb_info *info, struct vm_area_struct *vm
 	 *   Other flags can be set, and are documented in
 	 *   include/linux/mm.h
 	 */
-	vma->vm_flags |= VM_MAYSHARE;
+	vma->vm_flags |= VM_MAYSHARE | VM_SHARED;
 
 	return 0;
 }
Signature · 7 lines
1.5.4.3

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace