Skip to contentSkip to conversation

ppc4xx: Mask 'vec' with 0x1f in uic_interrupt() for bit set/clear

PATCH New Stefan Roese 1 participant 1 message Mar 27, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Mask 'vec' with 0x1f in uic_interrupt() for bit set/clear

---
 cpu/ppc4xx/interrupts.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
cpu/ppc4xx/interrupts.c +4 -3
index 698bcb5..8620e2b 100644
@@ -218,15 +218,16 @@ static void uic_interrupt(u32 uic_base, int vec_base)
 			} else {
 				set_dcr(uic_base + UIC_ER,
 					get_dcr(uic_base + UIC_ER) &
-					~(0x80000000 >> vec));
+					~(0x80000000 >> (vec & 0x1f)));
 				printf("Masking bogus interrupt vector %d"
 				       " (UIC_BASE=0x%x)\n", vec, uic_base);
 			}
 
 			/*
-			 * After servicing the interrupt, we have to remove the status indicator.
+			 * After servicing the interrupt, we have to remove the
+			 * status indicator
 			 */
-			set_dcr(uic_base + UIC_SR, (0x80000000 >> vec));
+			set_dcr(uic_base + UIC_SR, (0x80000000 >> (vec & 0x1f)));
 		}
 
 		/*
Signature · 1 line
1.5.4.4