rt2500pci, infinite calls to rt2x00mc_configure_filter
Hi Ivo,
with the latest changes, I guess in particular the commit "rt2x00: Fix in _atomic() usage" changing the flags for rt2500pci results in infinite calls to the new "rt2x00mc_configure_filter" in rt2x00mac.c. I noticed this after applying the attached patch that I've been using to debug some hostapd problems. All it does is add some printk's, I don't think it can cause the problem, right?
I use compat-wireless, to test stuff on a fedora system, this is the uname -a:
Linux steady.steadydecline.net 2.6.24.3-50.fc8 #1 SMP Thu Mar 20 13:39:08 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux
this checkout gives the problem (most recent wireless-testing):
mac80211-v2.6.25_rc7_3570_g78f8e64_080329-1.x86_64.rpm while this one does not:
mac80211-v2.6.25_rc5_2672_g57b58cd_080326-1.x86_64.rpm
with the patch (see attachment) applied, I get this in the logs, upon running hostapd:
-------------------------------------------------------------
Mar 29 14:25:49 steady kernel: rt2500pci filter_flags: 2 Mar 29 14:25:49 steady kernel:last message repeated 423 times Mar 29 14:25:49 steady kernel: rt2500pci filte0pci filter_flags: 2 Mar 29 14:25:49 steady kernel: rt2500pci filter_flags: 2 Mar 29 14:25:49 steady kernel:last message repeated 139 times
------------------------------------------------------------
this continues forever, spamming the logs, and eventually making the system unresponsive, requiring a reboot.
without the patch adding the printk to rt2x00mac_configure_filter, I get this soft lockup:
------------------------------------------------------------
rt2500pci MAC changed: 00:0c:f6:14:05:19 ADDRCONF(NETDEV_UP): wlan1: link is not ready
BUG: soft lockup - CPU#0 stuck for 11s! [rt2500pci:1541] CPU 0: Modules linked in: cpufreq_stats nfsd lockd nfs_acl auth_rpcgss exportfs
autofs4 fuse rfcomm l2cap sunrpc ipt_REJECT xt_multiport iptable_filter ipt_MASQUERADE ipt_REDIRECT iptable_nat nf_nat nf_conntrack_ipv4 ipt_TOS iptable_mangle ip_tables nf_conntrack_ipv6 xt_state nf_conntrack xt_tcpudp ip6t_ipv6header ip6t_REJECT ip6table_filter ip6_tables x_tables ipv6 cpufreq_ondemand acpi_cpufreq ext2 dm_mirror dm_multipath dm_mod wm8775 cx25840 msp3400 saa7115 tuner tea5767 tda8290 tuner_simple snd_hda_intel mt20xx snd_seq_dummy tea5761 snd_seq_oss snd_seq_midi_event snd_seq arc4 snd_seq_device ecb snd_pcm_oss snd_mixer_oss blkcipher snd_pcm ivtv i2c_algo_bit cx2341x snd_timer tveeprom snd_page_alloc rt2500pci(U) rt2x00pci(U) rt2x00lib(U) videodev rfkill snd_hwdep input_polldev firewire_ohci v4l2_common firewire_core crc_itu_t v4l1_compat rtl8187(U) mac80211(U) snd ati_remote2 r8169 pcspkr eeprom_93cx6(U) lirc_atiusb cfg80211(U) lirc_dev soundcore hci_usb button iTCO_wdt i2c_i801 i2c_core bluetooth iTCO_vendor_support sky2 sr_mod sg floppy cdrom ahci pata_jmicron ata_generic ata_piix pata_acpi libata sd_mod scsi_mod raid456 async_xor async_memcpy async_tx xor ext3 jbd mbcache uhci_hcd ohci_hcd ehci_hcd
Pid: 1541, comm: rt2500pci Not tainted 2.6.24.3-50.fc8 #1
RIP: 0010:[<ffffffff8126986b>] [<ffffffff8126986b>] _spin_unlock_irqrestore+0x8/0x9 RSP: 0018:ffff8101285d7e98 EFLAGS: 00000202 RAX: ffff81012d975fa0 RBX: ffffffff8824002e RCX: 0000000000000000 RDX: 0000000300000000 RSI: 0000000000000202 RDI: ffff81012d975f80 RBP: ffff81012d975f98 R08: ffff81012d975f88 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000300000000 R13: ffffffffffffff10 R14: ffffffff8824002e R15: ffffffffffffffff FS: 0000000000000000(0000) GS:ffffffff813cb000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000003ce5e9afa0 CR3: 0000000122418000 CR4: 00000000000006a0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Call Trace: [<ffffffff81045ba6>] queue_work+0x37/0x40 [<ffffffff88240065>] :rt2x00lib:rt2x00lib_packetfilter_scheduled +0x37/0x3c [<ffffffff81045635>] run_workqueue+0x7f/0x10b [<ffffffff81045f3d>] worker_thread+0x0/0xe4 [<ffffffff81046017>] worker_thread+0xda/0xe4 [<ffffffff81049221>] autoremove_wake_function+0x0/0x2e [<ffffffff810490f2>] kthread+0x47/0x75 [<ffffffff8100cca8>] child_rip+0xa/0x12 [<ffffffff81034326>] check_preempt_wakeup+0x0/0xa5 [<ffffffff810490ab>] kthread+0x0/0x75 [<ffffffff8100cc9e>] child_rip+0x0/0x12 ------------------------------------------------------------
I guess this softlock might be prevented from winding up in the logs with the printk I've added, because that spams the log.
any ideas?
best regards,
Bas Hulsken
rt2500pci.c renamed from drivers/net/wireless/rt2x00/rt2500pci.c +18 -2
@@ -49,6 +49,21 @@* the access attempt is considered to have failed, * and we will print an error. */ + +#define MAC2STR_BUFFERS 4 + +static inline char *mac2str (u8 *mac) +{ +static atomic_t a =ATOMIC_INIT (0 ); +static char bufs[MAC2STR_BUFFERS ][6 *3 ]; +char *str; + + str = bufs[atomic_inc_return (&a) & (MAC2STR_BUFFERS -1 )]; +sprintf (str,"%02x:%02x:%02x:%02x:%02x:%02x" , + mac[0 ], mac[1 ], mac[2 ], mac[3 ], mac[4 ], mac[5 ]); +return str; +} +static u32 rt2500pci_bbp_check (struct rt2x00_dev *rt2x00dev) {u32 reg;
@@ -329,10 +344,11 @@ static void rt2500pci_config_intf(structrt2x00pci_register_write (rt2x00dev,CSR14 , reg); } -if (flags &CONFIG_UPDATE_MAC ) +if (flags &CONFIG_UPDATE_MAC ) {rt2x00pci_register_multiwrite (rt2x00dev,CSR3 , conf->mac,sizeof (conf->mac)); - +printk (KERN_INFO "rt2500pci MAC changed: %s\n" ,mac2str ((u8 *)conf->mac)); + }if (flags &CONFIG_UPDATE_BSSID )rt2x00pci_register_multiwrite (rt2x00dev,CSR5 , conf->bssid,sizeof (conf->bssid));
rt2x00mac.c renamed from drivers/net/wireless/rt2x00/rt2x00mac.c +1 -1
@@ -416,7 +416,7 @@ void rt2x00mac_configure_filter(struct iif (rt2x00dev->packet_filter == *total_flags)return ; rt2x00dev->packet_filter = *total_flags; - +printk (KERN_INFO "rt2500pci filter_flags: %d\n" , rt2x00dev->packet_filter);if (!test_bit (DRIVER_REQUIRE_SCHEDULED , &rt2x00dev->flags))queue_work (rt2x00dev->hw->workqueue, &rt2x00dev->filter_work);else
Hi,
Quoted 6 lines
with the latest changes, I guess in particular the commit "rt2x00: Fix in
_atomic()usage" changing the flags for rt2500pci results in infinite calls to the new "rt2x00mc_configure_filter" inrt2x00mac.c. I noticed this after applying the attached patch that I've been using to debug some hostapd problems. All it does is add some printk's, I don't think it can cause the problem, right?
Oops...
I found the problem, patch coming will be released in a few minutes. :)
Ivo
Hi,
Quoted 11 lines · Ivo van Doorn
Hi,
Quoted 6 lines
with the latest changes, I guess in particular the commit "rt2x00: Fix in
_atomic()usage" changing the flags for rt2500pci results in infinite calls to the new "rt2x00mc_configure_filter" inrt2x00mac.c. I noticed this after applying the attached patch that I've been using to debug some hostapd problems. All it does is add some printk's, I don't think it can cause the problem, right?Oops...
I found the problem, patch coming will be released in a few minutes. :)
ok, that fixes it. Thanks!
unfortunately, I still can't get hostapd to work :( Do you have some ideas about this Ivo? I've already discussed this a bit with Johannes, but he couldn't find any obvious problems. It seems that EAPOL keys sent from my laptop to hostapd (running on the rt2500pci) don't arrive. Only when switching wlan1 to promiscuous, they arrive. Unfortunately then hostapd hangs (perhaps to unrelated things, perhaps due to the fact that wlan1 is promiscuous, I don't know.).
Here are some logs:
hostapd, without wlan1 set to promiscuous:
--------------------------------------------------------------------
wlan1: STA 00:1b:77:a4:db:26 WPA: sending 1/4 msg of 4-Way Handshake
WPA: Send EAPOL(version=1 secure=0 mic=0 ack=1 install=0 pairwise=8 kde_len=0 keyidx=0 encr=0)
STA 00:1b:77:a4:db:26 sent probe request for our SSID
MGMT (TX callback) ACKmgmt::proberesp cb
wlan1: STA 00:1b:77:a4:db:26 WPA: EAPOL-Key timeout
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state PTKSTART
wlan1: STA 00:1b:77:a4:db:26 WPA: sending 1/4 msg of 4-Way Handshake
WPA: Send EAPOL(version=1 secure=0 mic=0 ack=1 install=0 pairwise=8 kde_len=0 keyidx=0 encr=0)
wlan1: STA 00:1b:77:a4:db:26 WPA: EAPOL-Key timeout
--------------------------------------------------------------------
this repeats for a while, all the time giving EAPOL-Key timeout messages. tetherial -i mon.wlan1 on the hostapd machine shows that no EAPOL key's are received, while tetherial on the laptop shows that they are being sent.
this is the flag status when running hostapd; as printed with printk(KERN_INFO "rt2500pci filter_flags: %d\n", rt2x00dev->packet_filter);
rt2500pci filter_flags: 2
rt2500pci MAC changed: 00:0c:f6:14:05:19
hostapd, with wlan1 set to promiscuous:
--------------------------------------------------------------------
authentication: STA=00:1b:77:a4:db:26 auth_alg=0 auth_transaction=1 status_code=0 wep=0
New STA
wlan1: STA 00:1b:77:a4:db:26 IEEE 802.11: authentication OK (open system)
wlan1: STA 00:1b:77:a4:db:26 MLME:
MLME-AUTHENTICATE.indication(00:1b:77:a4:db:26, OPEN_SYSTEM)
wlan1: STA 00:1b:77:a4:db:26 MLME:
MLME-DELETEKEYS.request(00:1b:77:a4:db:26)
authentication reply: STA=00:1b:77:a4:db:26 auth_alg=0 auth_transaction=2 resp=0 (IE len=0)
MGMT (TX callback) ACKmgmt::auth cb
wlan1: STA 00:1b:77:a4:db:26 IEEE 802.11: authenticated
MGMTmgmt::assoc_req
association request: STA=00:1b:77:a4:db:26 capab_info=0x411 listen_interval=10
WME IE - hexdump(len=7): 00 50 f2 02 00 01 00
Validating WME IE: OUI 00:50:f2 OUI type 2 OUI sub-type 0 version 1 Failed to set CTS protect in kernel driver
Failed to set Short Slot Time option in kernel driver
Could not set preamble for kernel driver
new AID 1
wlan1: STA 00:1b:77:a4:db:26 IEEE 802.11: association OK (aid 1) MGMT (TX callback) ACKmgmt::assoc_resp cb
wlan1: STA 00:1b:77:a4:db:26 IEEE 802.11: associated (aid 1, accounting session 47EE6A5B-00000004)
wlan1: STA 00:1b:77:a4:db:26 MLME:
MLME-ASSOCIATE.indication(00:1b:77:a4:db:26)
wlan1: STA 00:1b:77:a4:db:26 MLME:
MLME-DELETEKEYS.request(00:1b:77:a4:db:26)
wlan1: STA 00:1b:77:a4:db:26 WPA: event 1 notification
wlan1: STA 00:1b:77:a4:db:26 WPA: start authentication
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state INITIALIZE
wlan1: STA 00:1b:77:a4:db:26 IEEE 802.1X: unauthorizing port
WPA: 00:1b:77:a4:db:26 WPA_PTK_GROUP entering state IDLE
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state AUTHENTICATION
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state AUTHENTICATION2
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state INITPSK
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state PTKSTART
wlan1: STA 00:1b:77:a4:db:26 WPA: sending 1/4 msg of 4-Way Handshake
WPA: Send EAPOL(version=1 secure=0 mic=0 ack=1 install=0 pairwise=8 kde_len=0 keyidx=0 encr=0)
IEEE 802.1X: 125 bytes from 00:1b:77:a4:db:26
IEEE 802.1X: version=1 type=3 length=121
wlan1: STA 00:1b:77:a4:db:26 WPA: received EAPOL-Key frame (2/4 Pairwise)
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state PTKCALCNEGOTIATING
WPA: PTK derivation - A1=00:0c:f6:14:05:19 A2=00:1b:77:a4:db:26
WPA: PMK - hexdump(len=32): [REMOVED]
WPA: PTK - hexdump(len=64): [REMOVED]
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state PTKCALCNEGOTIATING2
WPA: 00:1b:77:a4:db:26 WPA_PTK entering state PTKINITNEGOTIATING
--------------------------------------------------------------------
after this, hostapd hangs, and after ctrl-C it outputs this:
--------------------------------------------------------------------
eloop: could not process SIGINT or SIGTERM in two seconds. Looks like there
is a bug that ends up in a busy loop that prevents clean shutdown. Killing program forcefully.
--------------------------------------------------------------------
the flag status; as printed with printk(KERN_INFO "rt2500pcifilter_flags: %d\n", rt2x00dev->packet_filter);
when wlan1 is promiscuous:
device mon.wlan1 entered promiscuous mode
rt2500pci filter_flags: 67
device mon.wlan1 left promiscuous mode
rt2500pci filter_flags: 2
so obviously authentication get's a lot further with wlan1 in promiscuous mode, and EAPOL keys sent from the laptop are being received. Any clues as to why this happens? Is 2 (00000010B) the correct flag status? Or 67 (01000011B). Hope you can see what's going wrong here.. I don't even know if the issue is with rt2x00 or somewhere else, although Johannes can use hostapd on a broadcom chipset.
thanks a lot for your help,
Bas
Quoted 6 lines
Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Quoted 5 lines
--------------------------------------------------------------------
this repeats for a while, all the time giving EAPOL-Key timeout messages. tetherial -i mon.wlan1 on the hostapd machine shows that no EAPOL key's are received, while tetherial on the laptop shows that they are being sent.
Could you enable debugfs and use the tools here:
http://www-user.rhrk.uni-kl.de/~nissler/rt2x00/index.html
To create a dump of the frames as they are actually send out from the driver to the hardware including the status report. This will tell if rt2x00 is actually bringing the frame to the hardware correctly.
Quoted 6 lines
this is the flag status when running hostapd; as printed with
printk(KERN_INFO "rt2500pci filter_flags: %d\n", rt2x00dev->packet_filter);rt2500pci
filter_flags: 2
rt2500pci MAC changed: 00:0c:f6:14:05:19
Packet filter flags of 2 sounds a bit restrictive.
Johannes, for Master mode shouldn't the following flags be set as well:FIF_PROMISC_IN_BSSFIF_CONTROL
Or should the driver enable those automatically when master mode is enabled?
Quoted 11 lines
IEEE 802.1X: 125 bytes from 00:1b:77:a4:db:26
IEEE 802.1X: version=1 type=3 length=121
wlan1: STA 00:1b:77:a4:db:26 WPA: received EAPOL-Key frame (2/4 Pairwise)
WPA: 00:1b:77:a4:db:26WPA_PTKentering state PTKCALCNEGOTIATING
WPA: PTK derivation - A1=00:0c:f6:14:05:19 A2=00:1b:77:a4:db:26
WPA: PMK - hexdump(len=32): [REMOVED]
WPA: PTK - hexdump(len=64): [REMOVED]
WPA: 00:1b:77:a4:db:26WPA_PTKentering state PTKCALCNEGOTIATING2
WPA: 00:1b:77:a4:db:26WPA_PTKentering state PTKINITNEGOTIATING
--------------------------------------------------------------------
I'm not sure what is happening here...
Ivo
Quoted 7 lines · Ivo van Doorn
Could you enable debugfs and use the tools here:
http://www-user.rhrk.uni-kl.de/~nissler/rt2x00/index.htmlTo create a dump of the frames as they are actually send out from the driver to the hardware including the status report. This will tell if rt2x00 is actually bringing the frame to the hardware correctly.
I think you've got that back to front - If I'm reading the thread correctly the suspicion is the data is being transmitted correctly by the remote end and is being lost somehere between the rt2500pci antenna and user space.
The tools would still be helpful to see if a packet is being received by the hardware and lost in the stack (maybe it doesn't like something about the received packet) or if it is not even getting as far as the rt2x00 driver.
Quoted 4 lines
Quoted 4 lines
this is the flag status when running hostapd; as printed with
printk(KERN_INFO "rt2500pci filter_flags: %d\n", rt2x00dev->packet_filter);
Quoted 9 lines
Quoted 2 lines
rt2500pci
filter_flags: 2
rt2500pci MAC changed: 00:0c:f6:14:05:19Packet filter flags of 2 sounds a bit restrictive.
Johannes, for Master mode shouldn't the following flags be set as well:
FIF_PROMISC_IN_BSSFIF_CONTROL
Ivo,
Don't forget that there was no response to the request for someone to test if broadcast packets were received in monitor mode on the older hardware so if the filter flags don't select multicast traffic we could be losing broadcast traffic too. I'm not sure if the stack will be reporting any active multicast groups in AP mode. (For the benefit of others the only reason normal broadcast traffic was working was because there was always a multicast group present, Ivo's request is linked below.)
Hi Adam, Ivo,
Quoted 16 lines · Adam Baker
Quoted 7 lines · Ivo van Doorn
Could you enable debugfs and use the tools here:
http://www-user.rhrk.uni-kl.de/~nissler/rt2x00/index.htmlTo create a dump of the frames as they are actually send out from the driver to the hardware including the status report. This will tell if rt2x00 is actually bringing the frame to the hardware correctly.
I think you've got that back to front - If I'm reading the thread correctly the suspicion is the data is being transmitted correctly by the remote end and is being lost somehere between the rt2500pci antenna and user space.
Quoted 5 lines
The tools would still be helpful to see if a packet is being received by the hardware and lost in the stack (maybe it doesn't like something about the received packet) or if it is not even getting as far as the rt2x00 driver.
you're right Adam, it's the receiving part where it goes wrong, anyway, I've managed to enable debugfs, and the above mentioned tools, so I'll do some captures today for both normal and promiscuous mode, to see if, and why/how/where packets get lost.
Quoted 11 lines
Ivo,
Don't forget that there was no response to the request for someone to test if broadcast packets were received in monitor mode on the older hardware so if the filter flags don't select multicast traffic we could be losing broadcast traffic too. I'm not sure if the stack will be reporting any active multicast groups in AP mode. (For the benefit of others the only reason normal broadcast traffic was working was because there was always a multicast group present, Ivo's request is linked below.)
I would like to test for this, but I'm not quite sure how, I've read Ivo's original message, but I can't find the monitoring bug discussion Ivo is referring to. Would the frame captures on debugfs, again with the above mentioned tools test for this bug as well? Or is there something else I have to do?
thanks,
Bas Hulsken
Hi,
Quoted 9 lines
Quoted 9 lines
Ivo,
Don't forget that there was no response to the request for someone to test if broadcast packets were received in monitor mode on the older hardware so if the filter flags don't select multicast traffic we could be losing broadcast traffic too. I'm not sure if the stack will be reporting any active multicast groups in AP mode. (For the benefit of others the only reason normal broadcast traffic was working was because there was always a multicast group present, Ivo's request is linked below.)
Quoted 7 lines
Quoted 2 lines
I would like to test for this, but I'm not quite sure how, I've read Ivo's original message, but I can't find the monitoring bug discussion Ivo is referring to. Would the frame captures on debugfs, again with the above mentioned tools test for this bug as well? Or is there something else I have to do?
So far I have received 1 result for the above test request which indicated rt2500pci wasn't harmed with this bug. However, latest rt2x00 has Adam's patch active for all rt2x00 drivers (since the code is now handled in rt2x00mac.c).
So this means that that multicast bug should have no influence for this bug.
Ivo
Hi,
Quoted 16 lines · Ivo van Doorn
Quoted 8 lines
Quoted 8 lines
Don't forget that there was no response to the request for someone to test if broadcast packets were received in monitor mode on the older hardware so if the filter flags don't select multicast traffic we could be losing broadcast traffic too. I'm not sure if the stack will be reporting any active multicast groups in AP mode. (For the benefit of others the only reason normal broadcast traffic was working was because there was always a multicast group present, Ivo's request is linked below.)
Quoted 7 lines
Quoted 2 lines
I would like to test for this, but I'm not quite sure how, I've read Ivo's original message, but I can't find the monitoring bug discussion Ivo is referring to. Would the frame captures on debugfs, again with the above mentioned tools test for this bug as well? Or is there something else I have to do?
Quoted 4 lines
So far I have received 1 result for the above test request which indicated rt2500pci wasn't harmed with this bug. However, latest rt2x00 has Adam's patch active for all rt2x00 drivers (since the code is now handled in
rt2x00mac.c).
So this means that that multicast bug should have no influence for this bug.
ok, understood.
I've made the dumps you've asked for; at least I think so:
'/debug/ieee80211/phy2/rt2500pci/frame/dump' as mentioned in the rt2wtap doc does not exist for me, so I've captured from:
'/debug/ieee80211/phy1/rt2500pci/queue/dump' is that the new name or something?
anyway, I've made 2 dumps, one of an association attempt with wlan1 _not_ promiscuous (which fails because eapol keys sent by laptop are not received): hostapd_not_promisc_try2.tar.bz2
and one dump of an association attempt with wlan1 set to promiscuous (which fails later on, because hostapd locks up:hostapd_promisc_try1.tar.bz2. BTW, this lockup also seems to affect the driver state, if I want to use the interface again, I have to manually unload and reload the rt2500pci module).
the laptop has mac: 00:1b:77:a4:db:26, an the rt2500pci nic in the server trying to be an accesspoint is 00:0c:f6:14:05:19. So a wireshark filter like this wlan.da == 00:1b:77:a4:db:26 || wlan.sa == 00:1b:77:a4:db:26 shows the laptops traffic on the interface.
Quoted 1 line
From a quick look at the dumps, I found that again EAPOL key response
from the laptop is only received if wlan1 is set to promiscuous. At that point hostapd locks, and it sends out no more frames. The EAPOL key from the laptop is at frame 420 and 421 in the dump in hostapd_promisc_try1.tar.bz2.
well, I hope this can help you, but apparently the missing EAPOL key packets from the laptop also don't show up in these dumps in the non promiscuous case. So they apparently get lost before they are captured.
best regards, and many thanks,
Bas Hulsken
Quoted 5 lines · Bas Hulsken
I've made the dumps you've asked for; at least I think so:
'/debug/ieee80211/phy2/rt2500pci/frame/dump' as mentioned in the rt2wtap doc does not exist for me, so I've captured from:
'/debug/ieee80211/phy1/rt2500pci/queue/dump' is that the new name or something?
Yes. I need to update the documentation :-)
Mattias
Johannes Berg
maintainerHi Ivo,
Thanks for helping debug this. I haven't had a chance to run hostapd again, been far too busy. As it stands, I'm not sure when I can possibly get to that.
Quoted 10 lines
Quoted 2 lines
rt2500pci
filter_flags: 2
rt2500pci MAC changed: 00:0c:f6:14:05:19Packet filter flags of 2 sounds a bit restrictive.
Johannes, for Master mode shouldn't the following flags be set as well:
FIF_PROMISC_IN_BSSFIF_CONTROLOr should the driver enable those automatically when master mode is enabled?
The driver most definitely shouldn't do anything, but neither of those flags should be needed. In a BSS, all frames from the stations are addressed to the BSS-MAC, i.e. to the AP, so the regular MAC filter should allow them through without any sort of promisc. And control frames aren't needed, those are just ack/cts/... frames.
johannes
Hi,
Quoted 13 lines
Thanks for helping debug this. I haven't had a chance to run hostapd again, been far too busy. As it stands, I'm not sure when I can possibly get to that.
Quoted 9 lines
Quoted 2 lines
rt2500pci
filter_flags: 2
rt2500pci MAC changed: 00:0c:f6:14:05:19Packet filter flags of 2 sounds a bit restrictive.
Johannes, for Master mode shouldn't the following flags be set as well:
FIF_PROMISC_IN_BSSFIF_CONTROL
Quoted 7 lines
Quoted 1 line
Or should the driver enable those automatically when master mode is enabled?
The driver most definitely shouldn't do anything, but neither of those flags should be needed. In a BSS, all frames from the stations are addressed to the BSS-MAC, i.e. to the AP, so the regular MAC filter should allow them through without any sort of promisc. And control frames aren't needed, those are just ack/cts/... frames.
Ok, I think I found the problem. The packet filter in all Ralink devices have a TODS filter. Currently I had this only enabled when FIF_PROMISC_IN_BSS was set. I'll change this to a check that determines if master mode is enabled.
Ivo
Johannes Berg
maintainerHi,
Quoted 9 lines
Quoted 5 lines
The driver most definitely shouldn't do anything, but neither of those flags should be needed. In a BSS, all frames from the stations are addressed to the BSS-MAC, i.e. to the AP, so the regular MAC filter should allow them through without any sort of promisc. And control frames aren't needed, those are just ack/cts/... frames.
Ok, I think I found the problem. The packet filter in all Ralink devices have a TODS filter. Currently I had this only enabled when
FIF_PROMISC_IN_BSSwas set. I'll change this to a check that determines if master mode is enabled.
Ah, that would explain it. Bas, I'll scratch this item off my todo list, please get back to me if that doesn't fix it.
johannes