Skip to contentSkip to conversation

NULL noise: drivers/misc

PATCH In review Al Viro 2 participants 2 messages Mar 29, 2008 Char and misc drivers

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 NULL noise: drivers/misc

Signed-off-by Al Viro <[email protected]>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 drivers/misc/ibmasm/module.c  |    2 +-
 drivers/misc/lkdtm.c          |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/misc/fujitsu-laptop.c +1 -1
index 1cfd7f3..e2e7c05 100644
@@ -231,7 +231,7 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
 
 	if (!device || !acpi_driver_data(device))
 		return -EINVAL;
-	fujitsu->acpi_handle = 0;
+	fujitsu->acpi_handle = NULL;
 
 	return 0;
 }
drivers/misc/ibmasm/module.c +1 -1
index 4f9d4a9..b5f6add 100644
@@ -106,7 +106,7 @@ static int __devinit ibmasm_init_one(struct pci_dev *pdev, const struct pci_devi
 	sp->irq = pdev->irq;
 	sp->base_address = ioremap(pci_resource_start(pdev, 0),
 					pci_resource_len(pdev, 0));
-	if (sp->base_address == 0) {
+	if (!sp->base_address) {
 		dev_err(sp->dev, "Failed to ioremap pci memory\n");
 		result =  -ENODEV;
 		goto error_ioremap;
drivers/misc/lkdtm.c +1 -1
index c884730..1bfe5d1 100644
@@ -197,7 +197,7 @@ static int lkdtm_parse_commandline(void)
 {
 	int i;
 
-	if (cpoint_name == INVALID || cpoint_type == NONE ||
+	if (cpoint_name == NULL || cpoint_type == NULL ||
 					cpoint_count < 1 || recur_count < 1)
 		return -EINVAL;
Signature · 1 line
1.5.3.GIT
#1 lore raw
Quoted 7 lines · Al Viro
Signed-off-by Al Viro <[email protected]>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 drivers/misc/ibmasm/module.c  |    2 +-
 drivers/misc/lkdtm.c          |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Not duplicated in -mm, please apply.

Harvey