Skip to contentSkip to conversation

virtio: fix sparse return void-valued expression warnings

PATCH Applied Harvey Harrison 2 participants 2 messages Apr 3, 2008 virtio core

lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 1/7 virtio: fix sparse return void-valued expression warnings

drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression

Signed-off-by Harvey Harrison <[email protected]>
---
 drivers/virtio/virtio_pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/virtio/virtio_pci.c +2 -2
index c0df924..de102a6 100644
@@ -145,14 +145,14 @@ static void vp_set_status(struct virtio_device *vdev, u8 status)
 	struct virtio_pci_device *vp_dev = to_vp_device(vdev);
 	/* We should never be setting status to 0. */
 	BUG_ON(status == 0);
-	return iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+	iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
 }
 
 static void vp_reset(struct virtio_device *vdev)
 {
 	struct virtio_pci_device *vp_dev = to_vp_device(vdev);
 	/* 0 status means a reset. */
-	return iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+	iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
 }
 
 /* the notify function used when creating a virt queue */
Signature · 1 line
1.5.5.rc1.135.g8527
#1 lore raw
Quoted 3 lines · On Thursday 03 April 2008 10:33:34 Harvey Harrison wrote:

drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression

Hi Harvey,

This patch is in my tree, thanks.

Rusty.