Skip to contentSkip to conversation

xfs_io "BUG: lock held when returning to user space!" on suspend

DISCUSSION Jeremy Fitzhardinge 3 participants 5 messages Apr 2, 2008 – Apr 4, 2008

lore
Share & tools
lore
#0 lore raw

I'm getting this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
xfs_io/18796 is leaving the kernel with locks still held!
1 lock held by xfs_io/18796:
#0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87

when I suspend, possibly during an xfs-freeze. There don't seem to be any ill-effects.

Thanks,
J

#1 lore raw
Quoted 11 lines · Jeremy Fitzhardinge

I'm getting this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
xfs_io/18796 is leaving the kernel with locks still held!
1 lock held by xfs_io/18796:
#0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87

when I suspend, possibly during an xfs-freeze. There don't seem to be any ill-effects.

Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held across freeze_bdev()/thaw_bdev(), and they are issued via separate ioctls generally from separate processes. Not great design, but not a bug....

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
#2 lore raw
Quoted 10 lines · David Chinner
Quoted 9 lines · Jeremy Fitzhardinge

I'm getting this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
xfs_io/18796 is leaving the kernel with locks still held!
1 lock held by xfs_io/18796:
#0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87

Quoted 7 lines
Quoted 2 lines

when I suspend, possibly during an xfs-freeze. There don't seem to be any ill-effects.

Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held across freeze_bdev()/thaw_bdev(), and they are issued via separate ioctls generally from separate processes. Not great design, but not a bug....

Actually... we do consider that bugs.

#3 lore raw
Quoted 14 lines · Peter Zijlstra
Quoted 13 lines · David Chinner
Quoted 11 lines · Jeremy Fitzhardinge

I'm getting this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
xfs_io/18796 is leaving the kernel with locks still held!
1 lock held by xfs_io/18796:
#0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87

when I suspend, possibly during an xfs-freeze. There don't seem to be any ill-effects.

Quoted 6 lines
Quoted 4 lines

Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held across freeze_bdev()/thaw_bdev(), and they are issued via separate ioctls generally from separate processes. Not great design, but not a bug....

Actually... we do consider that bugs.

http://lkml.org/lkml/2007/10/27/135

Where Linus says:

Definitely not a sane thing to do. It should use ref-counting and/or a
single bit to say "busy".

#4 lore raw
In reply to Peter Zijlstra
Quoted 14 lines · Peter Zijlstra
Quoted 13 lines · David Chinner
Quoted 11 lines · Jeremy Fitzhardinge

I'm getting this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
xfs_io/18796 is leaving the kernel with locks still held!
1 lock held by xfs_io/18796:
#0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87

when I suspend, possibly during an xfs-freeze. There don't seem to be any ill-effects.

Quoted 6 lines
Quoted 4 lines

Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held across freeze_bdev()/thaw_bdev(), and they are issued via separate ioctls generally from separate processes. Not great design, but not a bug....

Actually... we do consider that bugs.

Ok, you're welcome to fix it then. It's way below my care factor right now....

FWIW, I did suggest that this needed fixing before FIFREEZE/FITHAW are introduced, but that hasn't happened yet.

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group