Skip to contentSkip to conversation

x86: fix miscompile

PATCH In review James Bottomley 2 participants 2 messages Apr 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: fix miscompile

This patch local to the x86 tree introduced a fairly obvious compile fault:

commit f22fc9998497af6c271385e2025e2fe71c6f15b0

Author: Ingo Molnar <[email protected]>
Date:   Wed Apr 2 12:20:18 2008 +0200

x86: allocate FPU context to init task

I've attached the fix below (INIT_THREAD is a #defined initializer, not an actual structure). However, if you get this tree into linux-next, they'll do a much better job of shaking out bugs like this than I could.

James

---

include/asm-x86/processor.h +1 -1
index d4686cf..2fad98d 100644
@@ -828,7 +828,7 @@ extern union thread_xstate init_xstate;
 	.sysenter_cs		= __KERNEL_CS,				  \
 	.io_bitmap_ptr		= NULL,					  \
 	.fs			= __KERNEL_PERCPU,			  \
-	.xstate			= &init_xstate;
+	.xstate			= &init_xstate,				  \
 }
 
 /*
#1 lore raw
Quoted 2 lines · James Bottomley

This patch local to the x86 tree introduced a fairly obvious compile fault:

thanks - i already pulled the original change.

Ingo