Skip to contentSkip to conversation

iwlwifi: Select also LEDS_TRIGGERS.

PATCH In review Priit Laes 3 participants 5 messages Apr 24, 2008 – Apr 26, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Priit Laes

author
#0 lore raw

PATCH 1/1 iwlwifi: Select also LEDS_TRIGGERS.

Following patch fixes build for me..

From f7288b194fa7984246f56f228712cb3dc6882294 Mon Sep 17 00:00:00 2001
From: Priit Laes <[email protected]>
Date: Thu, 24 Apr 2008 13:36:49 +0300
Subject: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

Signed-off-by Priit Laes <[email protected]>
---
 drivers/net/wireless/iwlwifi/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/wireless/iwlwifi/Kconfig +2 -0
index c4e631d..5518017 100644
@@ -52,6 +52,7 @@ config IWL4965_LEDS
 	depends on IWL4965
 	select MAC80211_LEDS
 	select LEDS_CLASS
+	select LEDS_TRIGGERS
 	select IWLWIFI_LEDS
 	---help---
 	  This option enables LEDS for the iwlwifi drivers

@@ -139,6 +140,7 @@ config IWL3945_LEDS
 	depends on IWL3945
 	select MAC80211_LEDS
 	select LEDS_CLASS
+	select LEDS_TRIGGERS
 	---help---
 	  This option enables LEDS for the iwl3945 driver.
Signature · 1 line
1.5.4.5
#1 lore raw

Shouldn't be this already covered by MAC80211_LEDS

depends on IWL4965
select MAC80211_LEDS
select LEDS_CLASS
+ select LEDS_TRIGGERS
select IWLWIFI_LEDS

Quoted 2 lines · Priit Laes

Following patch fixes build for me..

author
#2 lore raw

=C3=9Chel kenal p=C3=A4eval, N, 2008-04-24 kell 14:24, kirjutas Tomas W= inkler:

drivers/net/wireless/iwlwifi/Kconfig config IWL4965_LEDS · line 56

Quoted 7 lines

Shouldn't be this already covered by MAC80211_LEDS =20
depends on IWL4965

drivers/net/wireless/iwlwifi/Kconfig +1 -0
 	select MAC80211_LEDS
 	select LEDS_CLASS
+	select LEDS_TRIGGERS
 	select IWLWIFI_LEDS

Compile failed for me until I selected LEDS_TRIGGERS myself. --
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 4 lines · Johannes Berg
Quoted 1 line · Tomas Winkler

Shouldn't be this already covered by MAC80211_LEDS

No, select isn't transitive.

Oh boy I hate when things are not intuitive... force me to read manuals ;) Thanks
Tomas

Quoted 2 lines

johannes