Skip to contentSkip to conversation

ibm_newemac: Increase MDIO timeouts

PATCH Applied Benjamin Herrenschmidt 4 participants 6 messages Apr 23, 2008 – Apr 26, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Benjamin Herrenschmidt

author
#0 lore raw

PATCH 1/1 ibm_newemac: Increase MDIO timeouts

This patch doubles the MDIO timeouts in EMAC as there are field cases where they are two short to communicate with some PHYs.

Signed-off-by Benjamin Herrenschmidt <[email protected]>

---

 drivers/net/ibm_newemac/core.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/ibm_newemac/core.c +4 -4
@@ -738,7 +738,7 @@ static int __emac_mdio_read(struct emac_
 		rgmii_get_mdio(dev->rgmii_dev, dev->rgmii_port);
 
 	/* Wait for management interface to become idle */
-	n = 10;
+	n = 20;
 	while (!emac_phy_done(dev, in_be32(&p->stacr))) {
 		udelay(1);
 		if (!--n) {

@@ -763,7 +763,7 @@ static int __emac_mdio_read(struct emac_
 	out_be32(&p->stacr, r);
 
 	/* Wait for read to complete */
-	n = 100;
+	n = 200;
 	while (!emac_phy_done(dev, (r = in_be32(&p->stacr)))) {
 		udelay(1);
 		if (!--n) {

@@ -810,7 +810,7 @@ static void __emac_mdio_write(struct ema
 		rgmii_get_mdio(dev->rgmii_dev, dev->rgmii_port);
 
 	/* Wait for management interface to be idle */
-	n = 10;
+	n = 20;
 	while (!emac_phy_done(dev, in_be32(&p->stacr))) {
 		udelay(1);
 		if (!--n) {

@@ -836,7 +836,7 @@ static void __emac_mdio_write(struct ema
 	out_be32(&p->stacr, r);
 
 	/* Wait for write to complete */
-	n = 100;
+	n = 200;
 	while (!emac_phy_done(dev, in_be32(&p->stacr))) {
 		udelay(1);
 		if (!--n) {
#2 lore raw
In reply to Benjamin Herrenschmidt
Quoted 2 lines · Benjamin Herrenschmidt

This patch doubles the MDIO timeouts in EMAC as there are field cases where they are two short to communicate with some PHYs.

I guess them being "two short" is why they needed to be doubled. :-)

-Bill

author
#3 lore raw
Quoted 6 lines · Bill Fink
Quoted 2 lines · Benjamin Herrenschmidt

This patch doubles the MDIO timeouts in EMAC as there are field cases where they are two short to communicate with some PHYs.

I guess them being "two short" is why they needed to be doubled. :-)

Well, in that case, it makes sense, it's still pretty short and better safe than sorry. On day I may look at actually measuring PHYs and see if it's worth trying to do sleeping waits in there.

Ben.

#4 lore raw
Quoted 4 lines · On Sat, 26 Apr 2008 08:22:38 +1000 Benjamin Herrenschmidt…
Quoted 2 lines · Bill Fink

On Wed, 23 Apr 2008, Benjamin Herrenschmidt wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

This patch doubles the MDIO timeouts in EMAC as there are field cases where they are two short to communicate with some PHYs.

I guess them being "two short" is why they needed to be doubled. :-)

Well, in that case, it makes sense, it's still pretty short and better safe than sorry. On day I may look at actually measuring PHYs and see if it's worth trying to do sleeping waits in there.

I think you missed Bill's joke. Read your original email and spot the typo, then read Bill's pun.

And stop emailing before you eat breakfast ;)

josh

author
#5 lore raw
Quoted 5 lines · Josh Boyer
Quoted 1 line
Quoted 1 line

I guess them being "two short" is why they needed to be

doubled. :-)

Quoted 2 lines

Well, in that case, it makes sense, it's still pretty short and

better

Quoted 8 lines
Quoted 1 line

safe than sorry. On day I may look at actually measuring PHYs and

see if

Quoted 1 line

it's worth trying to do sleeping waits in there.

I think you missed Bill's joke. Read your original email and spot the typo, then read Bill's pun.

And stop emailing before you eat breakfast ;)

Hrm ... yeah allright I missed my initial typo and I missed Bill joke :-) looks like another case of replying while still half asleep ...

Ben.