Skip to contentSkip to conversation

drivers: atm, char fix integer as NULL pointer warnings

PATCH In review Harvey Harrison 2 participants 2 messages Apr 28, 2008 – Apr 30, 2008

Subsystems (2)
Char and misc drivers ATM
lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 4/4 drivers: atm, char fix integer as NULL pointer warnings

drivers/atm/nicstar.c:418:25: warning: Using plain integer as NULL pointer drivers/char/drm/r128_cce.c:820:25: warning: Using plain integer as NULL pointer drivers/char/tty_io.c:1183:10: warning: Using plain integer as NULL pointer

Signed-off-by Harvey Harrison <[email protected]>
---
 drivers/atm/nicstar.c       |    2 +-
 drivers/char/drm/r128_cce.c |    2 +-
 drivers/char/tty_io.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/atm/nicstar.c +1 -1
index 38c769f..3da804b 100644
@@ -415,7 +415,7 @@ static int __devinit ns_init_card(int i, struct pci_dev *pcidev)
    card->pcidev = pcidev;
    membase = pci_resource_start(pcidev, 1);
    card->membase = ioremap(membase, NS_IOREMAP_SIZE);
-   if (card->membase == 0)
+   if (!card->membase)
    {
       printk("nicstar%d: can't ioremap() membase.\n",i);
       error = 3;
drivers/char/drm/r128_cce.c +1 -1
index f36adbd..c31afbd 100644
@@ -817,7 +817,7 @@ static struct drm_buf *r128_freelist_get(struct drm_device * dev)
 	for (i = 0; i < dma->buf_count; i++) {
 		buf = dma->buflist[i];
 		buf_priv = buf->dev_private;
-		if (buf->file_priv == 0)
+		if (!buf->file_priv)
 			return buf;
 	}
drivers/char/tty_io.c +1 -1
index 4d3c701..98b65a2 100644
@@ -1180,7 +1180,7 @@ struct tty_driver *tty_find_polling_driver(char *name, int *line)
 		if (*str == ',')
 			str++;
 		if (*str == '\0')
-			str = 0;
+			str = NULL;
 
 		if (tty_line >= 0 && tty_line <= p->num && p->poll_init &&
 				!p->poll_init(p, tty_line, str)) {
Signature · 1 line
1.5.5.1.270.g89765
Acked-by on v1 4/4
#1 lore raw

drivers/char/tty_io.c struct tty_driver *tty_find_polling_driver(char *name, int *line) · line 1186

Quoted 13 lines
drivers/char/tty_io.c +1 -1
index 4d3c701..98b65a2 100644
@@ -1180,7 +1180,7 @@ struct tty_driver *tty_find_polling_driver(char *name, int *line)
 		if (*str == ',')
 			str++;
 		if (*str == '\0')
-			str = 0;
+			str = NULL;
 
 		if (tty_line >= 0 && tty_line <= p->num && p->poll_init &&
 				!p->poll_init(p, tty_line, str)) {
Acked-by Alan Cox <[email protected]>