libertas: fix use-before-check violation
PATCH 1/1 libertas: fix use-before-check violation
[PATCH] fix use-before-check violation
According to Coverity (kudo's to Adrian Bunk), we had one use-before-check bug in libe libertas driver. This patch fixes this issue.
Signed-off-by Holger Schurig <[email protected]>
drivers/net/wireless/libertas/scan.c +2 -1
@@ -298,7 +298,8 @@ static int lbs_do_scan(struct lbs_privatuint8_t *tlv;/* pointer into our current, growing TLV storage area */ lbs_deb_enter_args (LBS_DEB_SCAN ,"bsstype %d, chanlist[].chan %d, chan_count %d" , - bsstype, chan_list[0 ].channumber, chan_count); + bsstype, chan_list ? chan_list[0 ].channumber :-1 , + chan_count);/* create the fixed part for scan command */ scan_cmd =kzalloc (MAX_SCAN_CFG_ALLOC ,GFP_KERNEL );
Quoted 6 lines · Holger Schurig
[PATCH] fix use-before-check violation
According to Coverity (kudo's to Adrian Bunk), we had one use-before-check bug in libe libertas driver. This patch fixes this issue.
Signed-off-by Holger Schurig <[email protected]>
Acked-by Dan Williams <[email protected]>
Quoted 14 lines
Index:
wireless-testing/drivers/net/wireless/libertas/scan.c
===================================================================drivers/net/wireless/libertas/scan.c +2
-1@@ -298,7 +298,8 @@ static int lbs_do_scan(struct lbs_privatuint8_t *tlv;/* pointer into our current, growing TLV storage area */ lbs_deb_enter_args (LBS_DEB_SCAN ,"bsstype %d, chanlist[].chan %d, chan_count %d" , - bsstype, chan_list[0 ].channumber, chan_count); + bsstype, chan_list ? chan_list[0 ].channumber :-1 , + chan_count);/* create the fixed part for scan command */ scan_cmd =kzalloc (MAX_SCAN_CFG_ALLOC ,GFP_KERNEL );