Skip to contentSkip to conversation

: Fix remote PHY initial link state.

PATCH Applied Michael Chan 2 participants 2 messages Apr 30, 2008 – May 2, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Michael Chan

author
#0 lore raw

PATCH 2/6 : Fix remote PHY initial link state.

[BNX2]: Fix remote PHY initial link state.

On some remote PHY blade systems, the driver receives no initial link interrupt. As a result, the GMII/MII MAC mode does not get setup properly. To fix this problem, we add an initial poll of the link state after chip reset.

With this change, the setting of the initial carrier state in the init code can be eliminated.

Signed-off-by Michael Chan <[email protected]>
Signed-off-by Benjamin Li <[email protected]>
---
 drivers/net/bnx2.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)
drivers/net/bnx2.c +2 -7
index 284dda2..9c6f21f 100644
@@ -4214,13 +4214,6 @@ bnx2_init_remote_phy(struct bnx2 *bp)
 		if (netif_running(bp->dev)) {
 			u32 sig;
 
-			if (val & BNX2_LINK_STATUS_LINK_UP) {
-				bp->link_up = 1;
-				netif_carrier_on(bp->dev);
-			} else {
-				bp->link_up = 0;
-				netif_carrier_off(bp->dev);
-			}
 			sig = BNX2_DRV_ACK_CAP_SIGNATURE |
 			      BNX2_FW_CAP_REMOTE_PHY_CAPABLE;
 			bnx2_shmem_wr(bp, BNX2_DRV_ACK_CAP_MB, sig);

@@ -4877,6 +4870,8 @@ bnx2_init_nic(struct bnx2 *bp)
 	spin_lock_bh(&bp->phy_lock);
 	bnx2_init_phy(bp);
 	bnx2_set_link(bp);
+	if (bp->phy_flags & BNX2_PHY_FLAG_REMOTE_PHY_CAP)
+		bnx2_remote_phy_event(bp);
 	spin_unlock_bh(&bp->phy_lock);
 	return 0;
 }
Signature · 1 line
1.5.5.GIT
maintainer Applied
#1 lore raw

From: "Michael Chan" <[email protected]>
Date: Wed, 30 Apr 2008 15:51:01 -0700

Quoted 7 lines

[BNX2]: Fix remote PHY initial link state.

On some remote PHY blade systems, the driver receives no initial link interrupt. As a result, the GMII/MII MAC mode does not get setup properly. To fix this problem, we add an initial poll of the link state after chip reset.

Quoted 5 lines

With this change, the setting of the initial carrier state in the init code can be eliminated.

Signed-off-by Michael Chan <[email protected]>
Signed-off-by Benjamin Li <[email protected]>

Applied.