Remove deprecated speedstep-centrino driver
PATCH 1/1 Remove deprecated speedstep-centrino driver
Remove deprecated speedstep-centrino driver
Not 100% sure whether there are machines out there that still need the static Banias tables, Venkatesh?
--- arch/x86/kernel/cpu/cpufreq/Kconfig | 30 - arch/x86/kernel/cpu/cpufreq/Makefile | 1 arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c | 634 ----------------------- 3 files changed, 665 deletions(-)
arch/x86/kernel/cpu/cpufreq/Kconfig +0 -30
@@ -122,36 +122,6 @@ config X86_GX_SUSPMOD If in doubt, say N. -config X86_SPEEDSTEP_CENTRINO - tristate "Intel Enhanced SpeedStep (deprecated)" - select CPU_FREQ_TABLE - select X86_SPEEDSTEP_CENTRINO_TABLE if X86_32 - depends on X86_32 || (X86_64 && ACPI_PROCESSOR) - help - This is deprecated and this functionality is now merged into - acpi_cpufreq (X86_ACPI_CPUFREQ). Use that driver instead of - speedstep_centrino. - This adds the CPUFreq driver for Enhanced SpeedStep enabled - mobile CPUs. This means Intel Pentium M (Centrino) CPUs - or 64bit enabled Intel Xeons. - - To compile this driver as a module, choose M here: the - module will be called speedstep-centrino. - - For details, take a look at <file:Documentation/cpu-freq/>. - - If in doubt, say N. - -config X86_SPEEDSTEP_CENTRINO_TABLE - bool "Built-in tables for Banias CPUs" - depends on X86_32 && X86_SPEEDSTEP_CENTRINO - default y - help - Use built-in tables for Banias CPUs if ACPI encoding - is not available. - - If in doubt, say N. - config X86_SPEEDSTEP_ICH tristate "Intel Speedstep on ICH-M chipsets (ioport interface)" select CPU_FREQ_TABLE
arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c deleted +0 -634
634 lines not on this page · raw message
arch/x86/kernel/cpu/cpufreq/Makefile +0 -1
@@ -11,5 +11,4 @@ obj-$(CONFIG_X86_SPEEDSTEP_ICH) += spee obj-$(CONFIG_X86_SPEEDSTEP_LIB) += speedstep-lib.o obj-$(CONFIG_X86_SPEEDSTEP_SMI) += speedstep-smi.o obj-$(CONFIG_X86_ACPI_CPUFREQ) += acpi-cpufreq.o -obj-$(CONFIG_X86_SPEEDSTEP_CENTRINO) += speedstep-centrino.o obj-$(CONFIG_X86_CPUFREQ_NFORCE2) += cpufreq-nforce2.o
Quoted 4 lines · Thomas Renninger
Remove deprecated speedstep-centrino driver
Not 100% sure whether there are machines out there that still need the static Banias tables, Venkatesh?
Hmm, if we decide to remove this for 2.6.27, I think we should get a printk into .26 on module load to say that it's going away. This likely has more valid use cases than the clockmod driver, so I think a heads-up to any potential users of it who still haven't seen the warning in the Kconfig might be a good idea.
Dave
Quoted 12 lines · Dave Jones
Quoted 4 lines · Thomas Renninger
Remove deprecated speedstep-centrino driver
Not 100% sure whether there are machines out there that still need the static Banias tables, Venkatesh?
Hmm, if we decide to remove this for 2.6.27, I think we should get a printk into .26 on module load to say that it's going away. This likely has more valid use cases than the clockmod driver, so I think a heads-up to any potential users of it who still haven't seen the warning in the
Kconfigmight be a good idea.
The one function difference from cpufreq_acpi is that it doens't rely on acpi. On my laptop of the time that was a useful distinction, but it may have been more due to the shoddy state of acpi in Linux rather than the BIOS.
J
Quoted 14 lines · Jeremy Fitzhardinge
Quoted 12 lines · Dave Jones
Quoted 4 lines · Thomas Renninger
Remove deprecated speedstep-centrino driver
Not 100% sure whether there are machines out there that still need the static Banias tables, Venkatesh?
Hmm, if we decide to remove this for 2.6.27, I think we should get a printk into .26 on module load to say that it's going away. This likely has more valid use cases than the clockmod driver, so I think a heads-up to any potential users of it who still haven't seen the warning in the
Kconfigmight be a good idea.
Quoted 4 lines
The one function difference from
cpufreq_acpiis that it doens't rely on acpi. On my laptop of the time that was a useful distinction, but it may have been more due to the shoddy state of acpi in Linux rather than the BIOS.
And that's the reason why I'd propose to keep it unless ACPI is actually required to be set to "y" on those systems -- which I doubt.
Best,
Dominik
Quoted 30 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Dominik Brodowski
Sent: Thursday, May 15, 2008 3:58 AM
To: Jeremy Fitzhardinge
Cc: Dave Jones; cpufreq
Subject: Re: [PATCH] Remove deprecated speedstep-centrino driverQuoted 5 lines · Jeremy Fitzhardinge
Quoted 4 lines · Dave Jones
Quoted 3 lines · Thomas Renninger
Remove deprecated speedstep-centrino driver
Not 100% sure whether there are machines out there that
still need the
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
static Banias tables, Venkatesh?
Hmm, if we decide to remove this for 2.6.27, I think we should get a printk into .26 on module load to say that it's going away. This likely has more valid use cases than the clockmod driver, so I think a heads-up to any potential users of it who still
haven't seen
Quoted 4 lines
Quoted 2 lines
the warning in the
Kconfigmight be a good idea.The one function difference from
cpufreq_acpiis that itdoens't rely on
Quoted 1 line
acpi. On my laptop of the time that was a useful
Quoted 9 lines
distinction, but it
Quoted 1 line
may have been more due to the shoddy state of acpi in Linux
rather than
Quoted 1 line
the BIOS.
And that's the reason why I'd propose to keep it unless ACPI is actually
required to be set to "y" on those systems -- which I doubt.
I don't think we can remove speedstep_centrino. There are few systems out
there that don't have proper ACPI P-state tables and depend on speedstep-centrino static table to change freq.
Thanks,
Venki