Skip to contentSkip to conversation

remove duplicate definition of sysfs_update_group()

PATCH In review Dmitri Vorobiev 1 participant 2 messages May 4, 2008 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove duplicate definition of sysfs_update_group()

The stub version of the sysfs_update_group() function is erroneously provided twice. This patch removes the redundant definition.

---
 include/linux/sysfs.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
include/linux/sysfs.h +0 -6
index 27bad59..7858eac 100644
@@ -196,12 +196,6 @@ static inline int sysfs_update_group(struct kobject *kobj,
 	return 0;
 }
 
-static inline int sysfs_update_group(struct kobject *kobj,
-				const struct attribute_group *grp)
-{
-	return 0;
-}
-
 static inline void sysfs_remove_group(struct kobject *kobj,
 				      const struct attribute_group *grp)
 {
Signature · 1 line
1.5.3
#1 lore raw

Dmitri Vorobiev пишет:

Quoted 3 lines

The stub version of the sysfs_update_group() function is erroneously provided twice. This patch removes the redundant definition.

Oops! I did not notice Ingo's fix when I was sending my patch:

http://lkml.org/lkml/2008/5/4/21

In Ingo's version, the changelog entry is much better than mine. Sorry for the noise.

Dmitri

Quoted 22 lines
---
 include/linux/sysfs.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
include/linux/sysfs.h +0 -6
index 27bad59..7858eac 100644
@@ -196,12 +196,6 @@ static inline int sysfs_update_group(struct kobject *kobj,
 	return 0;
 }
 
-static inline int sysfs_update_group(struct kobject *kobj,
-				const struct attribute_group *grp)
-{
-	return 0;
-}
-
 static inline void sysfs_remove_group(struct kobject *kobj,
 				      const struct attribute_group *grp)
 {