irqdomain: cdx: Switch to of_fwnode_handle()
PATCH 1/1 irqdomain: cdx: Switch to of_fwnode_handle()
of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.
---
This is an indepent patch, please apply directly.
The patch was previously a part of a large series [1], but I would like maintainers to feed the independent parts through their trees.
[1] https://lore.kernel.org/all/[email protected]/
--- drivers/cdx/cdx_msi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cdx/cdx_msi.c +2 -2
@@ -165,7 +165,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)struct device_node *parent_node;struct irq_domain *parent; - fwnode_handle =of_node_to_fwnode (np); + fwnode_handle =of_fwnode_handle (np); parent_node =of_parse_phandle (np,"msi-map" ,1 );if (!parent_node) {
@@ -173,7 +173,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)return NULL ; } - parent =irq_find_matching_fwnode (of_node_to_fwnode (parent_node),DOMAIN_BUS_NEXUS ); + parent =irq_find_matching_fwnode (of_fwnode_handle (parent_node),DOMAIN_BUS_NEXUS );if (!parent || !msi_get_domain_info (parent)) {dev_err (dev,"unable to locate ITS domain\n" );return NULL ;
Signature · 1 line
2.49.0
This will go via Greg's char-misc tree.
Quoted 7 lines · Jiri Slaby (SUSE)
of_node_to_fwnode()is irqdomain's reimplementation of the "officially" definedof_fwnode_handle(). The former is in the process of being removed, so use the latter instead.Signed-off-by Jiri Slaby (SUSE) <[email protected]>Cc Nipun Gupta <[email protected]>Cc Nikhil Agarwal <[email protected]>
Quoted 1 line · Nipun
This will go via Greg's char-misc tree.
Ah, then I should've sent this to him in the first place :). Uhm, but MAINTAINERS says:
AMD CDX BUS DRIVER
M: Nipun Gupta <[email protected]> M: Nikhil Agarwal <[email protected]> S: Maintained F: Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml F: drivers/cdx/* F: include/linux/cdx/*
@Greg: do you want me to resend, or will you dig it out with b4? It's:
Quoted 10 lines · Jiri Slaby (SUSE)
Quoted 7 lines
of_node_to_fwnode()is irqdomain's reimplementation of the "officially" definedof_fwnode_handle(). The former is in the process of being removed, so use the latter instead.Signed-off-by Jiri Slaby (SUSE) <[email protected]>Cc Nipun Gupta <[email protected]>Cc Nikhil Agarwal <[email protected]>Acked-by Nipun Gupta <[email protected]>
thanks,
Signature · 2 lines
js suse labs
Gupta, Nipun
maintainerQuoted 11 lines · Jiri Slaby
Quoted 1 line · Nipun
This will go via Greg's char-misc tree.
Ah, then I should've sent this to him in the first place :). Uhm, but
MAINTAINERSsays:
AMD CDX BUS DRIVER
M: Nipun Gupta <[email protected]>
M: Nikhil Agarwal <[email protected]>
S: Maintained
F:Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
F:drivers/cdx/*
F:include/linux/cdx/*
As a MAINTAINER, I/Nikhil need to review. We do not maintain a tree and patches go via Greg's tree.
Regards,
Nipun
Quoted 15 lines · Nipun
Quoted 11 lines · Jiri Slaby
Quoted 1 line · Nipun
This will go via Greg's char-misc tree.
Ah, then I should've sent this to him in the first place :). Uhm, but
MAINTAINERSsays:
AMD CDX BUS DRIVER
M: Nipun Gupta <[email protected]>
M: Nikhil Agarwal <[email protected]>
S: Maintained
F:Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
F:drivers/cdx/*
F:include/linux/cdx/*
Quoted 1 line
As a MAINTAINER, I/Nikhil need to review. We do not maintain a tree and patches go via Greg's tree.
Yes, I understand, but how are patches supposed to reach him? If he maintains this in his tree, perhaps drivers/cdx/* deserves an entry in the MISC entry too?
Signature · 2 lines
js suse labs
Quoted 14 lines · Jiri Slaby
Quoted 1 line · Nipun
This will go via Greg's char-misc tree.
Ah, then I should've sent this to him in the first place :). Uhm, but
MAINTAINERSsays:
AMD CDX BUS DRIVERM: Nipun Gupta <[email protected]> M: Nikhil Agarwal <[email protected]> S: Maintained F: Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml F: drivers/cdx/* F: include/linux/cdx/*
Quoted 3 lines
@Greg: do you want me to resend, or will you dig it out with b4? It's:
I can dig it out. but yes, the cdx stuff is a mess at times, it would be nice if the maintainers there would get a better workflow :(
thanks,
greg k-h