Skip to contentSkip to conversation

Make ADS5121 out-of-tree compiling compatible

U-Boot-Users New York Sun 3 participants 5 messages May 9, 2008 – May 12, 2008

lore
Share & tools
lore

York Sun

author
#0 lore raw

Wolfgang,

Please review the following patch which fixes the out-of-tree compiling.

Regards,

York

author
#1 lore raw

PATCH 1/1 Make out-of-tree compiling compatible

Signed-off-by York Sun <[email protected]>
---
 board/ads5121/Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
board/ads5121/Makefile +6 -1
index 8ace8a1..9b675f7 100644
@@ -23,9 +23,14 @@
 
 include $(TOPDIR)/config.mk
 
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
+
 LIB	= $(obj)lib$(BOARD).a
 
-COBJS-y	:= $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o
+COBJS-y	:= $(BOARD).o
+COBJS-y += ads5121_diu.o
+COBJS-y += ../freescale/common/fsl_diu_fb.o
+COBJS-y += ../freescale/common/fsl_logo_bmp.o
 COBJS-$(CONFIG_PCI) += pci.o
 
 COBJS	:= $(COBJS-y)
Signature · 1 line
1.5.2.2
#2 lore raw

PATCH 1/1 Make out-of-tree compiling compatible

Quoted 11 lines · In message <[email protected]> you wrote:
Signed-off-by York Sun <[email protected]>
---
 board/ads5121/Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
board/ads5121/Makefile +0 -0
index 8ace8a1..9b675f7 100644

board/ads5121/Makefile line 28

Quoted 6 lines
board/ads5121/Makefile +2 -0
@@ -23,9 +23,14 @@
 
 include $(TOPDIR)/config.mk
 
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
+
 LIB	= $(obj)lib$(BOARD).a

I'm missing some rule to remove that directory for "make clean" or "make distclean" ?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
	-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
	   stardate unknown.
author
#3 lore raw

PATCH 1/1 Make out-of-tree compiling compatible

Quoted 9 lines · Wolfgang Denk
Quoted 5 lines

include $(TOPDIR)/config.mk

+$(shell mkdir -p $(OBJTREE)/board/freescale/common) +
LIB = $(obj)lib$(BOARD).a

I'm missing some rule to remove that directory for "make clean" or "make distclean" ?

No, you are not. You have the following in Makefile

distclean: clobber unconfig

        rm -rf $(obj)*

endif

All temporary folders are removed.

I just resent you the v2 patch.

York

#4 lore raw

PATCH 1/1 Make out-of-tree compiling compatible

In reply to York Sun
Quoted 16 lines · York Sun
Signed-off-by York Sun <[email protected]>
---
 board/ads5121/Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
board/ads5121/Makefile +2 -0
index 8ace8a1..9b675f7 100644
@@ -23,9 +23,14 @@
 
 include $(TOPDIR)/config.mk
 
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
+

board/ads5121/Makefile line 36

Quoted 10 lines
board/ads5121/Makefile +4 -1
 LIB	= $(obj)lib$(BOARD).a
 
-COBJS-y	:= $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o
+COBJS-y	:= $(BOARD).o
+COBJS-y += ads5121_diu.o
+COBJS-y += ../freescale/common/fsl_diu_fb.o
+COBJS-y += ../freescale/common/fsl_logo_bmp.o
 COBJS-$(CONFIG_PCI) += pci.o
 
 COBJS	:= $(COBJS-y)

Why don't you just define CONFIG_FSL_DIU_FB in the ads5121 config.h? Then you don't have to build the common objects in this Makefile as board/freescale/common/Makefile will handle them.

- k