Skip to contentSkip to conversation

: add support the CF PCMCIA driver for Blackfin

PATCH In review Bryan Wu 3 participants 3 messages May 12, 2008 – May 13, 2008 Pcmcia

lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 : add support the CF PCMCIA driver for Blackfin

From: Michael Hennerich <[email protected]>

Signed-off-by Michael Hennerich <[email protected]>
Signed-off-by Bryan Wu <[email protected]>
---
 drivers/pcmcia/Kconfig          |    7 +
 drivers/pcmcia/Makefile         |    1 +
 drivers/pcmcia/bfin_cf_pcmcia.c |  324 +++++++++++++++++++++++++++++++++++++++
 include/pcmcia/cs_types.h       |    2 +-
 4 files changed, 333 insertions(+), 1 deletions(-)
 create mode 100644 drivers/pcmcia/bfin_cf_pcmcia.c
drivers/pcmcia/Kconfig +7 -0
index 1b0eb5a..e45402a 100644
@@ -263,6 +263,13 @@ config OMAP_CF
 	  Say Y here to support the CompactFlash controller on OMAP.
 	  Note that this doesn't support "True IDE" mode.
 
+config BFIN_CFPCMCIA
+	tristate "Blackfin CompactFlash PCMCIA Driver"
+	depends on PCMCIA && BLACKFIN
+	help
+	  Say Y here to support the CompactFlash PCMCIA driver for Blackfin.
+
+
 config AT91_CF
 	tristate "AT91 CompactFlash Controller"
 	depends on PCMCIA && ARCH_AT91RM9200
drivers/pcmcia/Makefile +1 -0
index 6f6478b..85c6cc9 100644
@@ -36,6 +36,7 @@ obj-$(CONFIG_PCMCIA_AU1X00)			+= au1x00_ss.o
 obj-$(CONFIG_PCMCIA_VRC4171)			+= vrc4171_card.o
 obj-$(CONFIG_PCMCIA_VRC4173)			+= vrc4173_cardu.o
 obj-$(CONFIG_OMAP_CF)				+= omap_cf.o
+obj-$(CONFIG_BFIN_CFPCMCIA)			+= bfin_cf_pcmcia.o
 obj-$(CONFIG_AT91_CF)				+= at91_cf.o
 obj-$(CONFIG_ELECTRA_CF)			+= electra_cf.o
drivers/pcmcia/bfin_cf_pcmcia.c new file +324 -0

324 lines not on this page · raw message

include/pcmcia/cs_types.h +1 -1
index 9a6bcc4..c3257c1 100644
@@ -21,7 +21,7 @@
 #include <sys/types.h>
 #endif
 
-#if defined(__arm__) || defined(__mips__) || defined(__avr32__)
+#if defined(__arm__) || defined(__mips__) || defined(__avr32__) || defined(bfin)
 /* This (ioaddr_t) is exposed to userspace & hence cannot be changed. */
 typedef u_int   ioaddr_t;
 #else
Signature · 1 line
1.5.5
#1 lore raw

drivers/pcmcia/bfin_cf_pcmcia.c line 308

Quoted 8 lines · Bryan Wu
drivers/pcmcia/bfin_cf_pcmcia.c new file +8 -0
+static struct device_driver bfin_cf_driver = {
+	.name		= (char *) driver_name,
+	.bus		= &platform_bus_type,
+	.probe		= bfin_cf_probe,
+	.remove		= __devexit_p(bfin_cf_remove),
+	.suspend 	= pcmcia_socket_dev_suspend,
+	.resume 	= pcmcia_socket_dev_resume,
+};

NAK. All platform device drivers must be of type 'struct platform_driver'.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#2 lore raw
Quoted 2 lines

-----Original Message-----
From: Russell King [mailto:[email protected]] On Behalf Of Russell

King

Quoted 3 lines

Sent: Montag, 12. Mai 2008 13:37
To: Bryan Wu
Cc: [email protected]; [email protected];

Michael

Quoted 5 lines

Hennerich
Subject: Re: [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for Blackfin

On Mon, May 12, 2008 at 06:46:40PM +0800, Bryan Wu wrote:

Quoted 10 lines

drivers/pcmcia/bfin_cf_pcmcia.c line 308

Quoted 8 lines
drivers/pcmcia/bfin_cf_pcmcia.c new file +8 -0
+static struct device_driver bfin_cf_driver = {
+	.name		= (char *) driver_name,
+	.bus		= &platform_bus_type,
+	.probe		= bfin_cf_probe,
+	.remove		= __devexit_p(bfin_cf_remove),
+	.suspend 	= pcmcia_socket_dev_suspend,
+	.resume 	= pcmcia_socket_dev_resume,
+};

NAK. All platform device drivers must be of type 'struct

platform_driver'.

Haven't looked at the code since a great while...

ACK - were going to update.

Best regards,
Michael

Quoted 5 lines

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: