Skip to contentSkip to conversation

infiniband/hw/nes/: avoid unnecessary memset

PATCH In review Christophe Jaillet 6 participants 6 messages May 12, 2008 – May 22, 2008

Subsystems (3)
Networking Network drivers InfiniBand
lore
Share & tools
lore

Christophe Jaillet

author
#0 lore raw

PATCH 1/1 infiniband/hw/nes/: avoid unnecessary memset

From: Christophe Jaillet <[email protected]>

Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c which :

1) Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc (i.e. 'listener').

Note: this patch is based on 'linux-2.6.25.tar.bz2'

Signed-off-by Christophe Jaillet <[email protected]>

---

drivers/infiniband/hw/nes/nes_cm.c.cj renamed from drivers/infiniband/hw/nes/nes_cm.c +0 -1
@@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
 			return NULL;
 		}
 
-		memset(listener, 0, sizeof(struct nes_cm_listener));
 		listener->loc_addr = htonl(cm_info->loc_addr);
 		listener->loc_port = htons(cm_info->loc_port);
 		listener->reused_node = 0;
#1 lore raw

PATCH 1/1 drivers/net/ehea - remove unnecessary memset after kzalloc

Signed-off-by Joe Perches <[email protected]>

---

 drivers/net/ehea/ehea_main.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/ehea/ehea_main.c +0 -2
index f9bc21c..fd4be0d 100644
@@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
 	port->vgrp = grp;
 
 	cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
 	if (!cb1) {
 		ehea_error("no mem for cb1");
 		goto out;
 	}
 
-	memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
-
 	hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
 				       H_PORT_CB1, H_PORT_CB1_ALL, cb1);
 	if (hret != H_SUCCESS)
 		ehea_error("modify_ehea_port failed");
 
 	kfree(cb1);
 out:
 	return;
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc

Quoted 21 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>

---

 drivers/net/ehea/ehea_main.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/ehea/ehea_main.c +0 -0
index f9bc21c..fd4be0d 100644
@@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
 	port->vgrp = grp;
 
 	cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
 	if (!cb1) {
 		ehea_error("no mem for cb1");
 		goto out;
 	}

drivers/net/ehea/ehea_main.c static void ehea_vlan_rx_register(struct net_device *dev, · line 2222

Quoted 10 lines
drivers/net/ehea/ehea_main.c +0 -2
-	memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
-
 	hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
 				       H_PORT_CB1, H_PORT_CB1_ALL, cb1);
 	if (hret != H_SUCCESS)
 		ehea_error("modify_ehea_port failed");
 
 	kfree(cb1);
 out:
 	return;

The patch looks good.

Acked-by Jan-Bernd Themann <[email protected]>

Thanks,
Jan-Bernd

#4 lore raw
In reply to Christophe Jaillet

Acked-by Faisal Latif<[email protected]>

Thanks
Faisal

Quoted 29 lines

From: Christophe Jaillet <[email protected]>

Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c which :

1) Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc (i.e. 'listener').

Note: this patch is based on 'linux-2.6.25.tar.bz2'

Signed-off-by Christophe Jaillet <[email protected]>

---

--- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17
04:49:44.000000000 +0200
+++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12
23:31:24.000000000 +0200

drivers/infiniband/hw/nes/nes_cm.c.cj renamed from drivers/infiniband/hw/nes/nes_cm.c +0 -1
@@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
 			return NULL;
 		}
 
-		memset(listener, 0, sizeof(struct nes_cm_listener));
 		listener->loc_addr = htonl(cm_info->loc_addr);
 		listener->loc_port = htons(cm_info->loc_port);
 		listener->reused_node = 0;