Add irq extra flags to 8250 serial driver
cover Add irq extra flags to 8250 serial driver
Hi Alan,
Thanks Javier for updating this patch according to you review. Do you think it is ok? If yes, I'd like to add these patches to Blackfin git-tree and will invite linus to pull later.
-Bryan
PATCH 1/2 : Added support for 8250-class UARTs in HV Sistemas H8606 board
From: Javier Herrero <[email protected]>
Added support for 8250-class UARTs in HV Sistemas H8606 board, modification in 8250.c driver for correct compilation with Blackfin
Besides, I think that there is more people using 8250-class UARTs with a different hardware than the H8606 board. This code can be shared by them.
--- drivers/serial/8250.c | 5 +++-- drivers/serial/8250.h | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/serial/8250.c +3 -2
@@ -43,6 +43,7 @@#include <asm/io.h> #include <asm/irq.h> +#include <asm/serial.h> #include "8250.h"
@@ -92,8 +93,6 @@ static unsigned int nr_uarts = CONFIG_SERIAL_8250_RUNTIME_UARTS;*/ #define CONFIG_HUB6 1 -#include <asm/serial.h> -/* * SERIAL_PORT_DFNS tells us about built-in ports that have no * standard enumeration mechanism. Platforms that can find all
@@ -1548,6 +1547,8 @@ static int serial_link_irq_chain(struct uart_8250_port *up) i->head = &up->list;spin_unlock_irq (&i->lock); + irq_flags |=SERIAL_EXTRA_IRQ_FLAGS ; + ret =request_irq (up->port.irq, serial8250_interrupt, irq_flags,"serial" , i);if (ret <0 )
drivers/serial/8250.h +5 -0
@@ -78,3 +78,8 @@ struct serial8250_config {#else #define ALPHA_KLUDGE_MCR 0#endif + +#ifndef SERIAL_EXTRA_IRQ_FLAGS +#define SERIAL_EXTRA_IRQ_FLAGS 0 +#endif +
Signature · 1 line
1.5.5
Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board
Quoted 5 lines · On Tue, 13 May 2008 12:14:28 +0800 Bryan Wu <[email protected]> wrote:
From: Javier Herrero <[email protected]>
Added support for 8250-class UARTs in HV Sistemas H8606 board, modification in 8250.c driver for correct compilation with Blackfin
Quoted 7 lines
Besides, I think that there is more people using 8250-class UARTs with a different hardware than the H8606 board. This code can be shared by them.
Signed-off-by Javier Herrero <[email protected]>Cc Alan Cox <[email protected]>Signed-off-by Bryan Wu <[email protected]>
Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board
Quoted 12 lines · Alan Cox
Quoted 9 lines · On Tue, 13 May 2008 12:14:28 +0800 Bryan Wu <[email protected]> wrote:
From: Javier Herrero <[email protected]>
Added support for 8250-class UARTs in HV Sistemas H8606 board, modification in 8250.c driver for correct compilation with Blackfin
Besides, I think that there is more people using 8250-class UARTs with a different hardware than the H8606 board. This code can be shared by them.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Javier Herrero <[email protected]>Cc Alan Cox <[email protected]>Signed-off-by Bryan Wu <[email protected]>Acked-by Alan Cox <[email protected]>
Thanks, I will apply this patch to Blackfin git-tree
-Bryan
PATCH 2/2 serial driver: add extra IRQ flag for 8250 serial driver
In reply to Bryan WuFrom: Javier Herrero <[email protected]>
--- include/asm-blackfin/serial.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) create mode 100644 include/asm-blackfin/serial.h
include/asm-blackfin/serial.h new file +5 -0
@@ -0,0 +1,5 @@ +/* +* include/asm-blackfin/serial.h +*/ + +#define SERIAL_EXTRA_IRQ_FLAGS IRQF_TRIGGER_HIGH
Signature · 1 line
1.5.5