/fs/partition/check.c : fix return value warning (V2)
cover /fs/partition/check.c : fix return value warning (V2)
Quoted 36 lines · Andrew Morton
Quoted 18 lines · On Sat, 10 May 2008 13:40:53 +0200 Abdel Benamrouche <[email protected]> wrote:
fs/partitions/check.c:381: warning: ignoring return value of___device_add___,
declared with attributewarn_unused_resultSigned-off-by Abdel Benamrouche <[email protected]>---
:100644 100644 6149e4b... 7a87fad... Mfs/partitions/check.cfs/partitions/check.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)fs/partitions/check.c +0
-1@@ -378,7 +378,13 @@ void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len,/* delay uevent until 'holders' subdir is created */ p->dev.uevent_suppress =1 ; -device_add (&p->dev);fs/partitions/check.c void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len, · line 390
Quoted 10 lines
fs/partitions/check.c +7
-0+if (device_add (&p->dev)) { +put_device (&p->dev); +free_part_stats (p); +kfree (p); +return ; + } +partition_sysfs_add_subdir (p); p->dev.uevent_suppress =0 ;if (flags &ADDPART_FLAG_WHOLEDISK )We should go further than this.
add_partition()just drops the error on the floor. It should be propagated back to callers, and callers should be modified to handle it appropriately.
Quoted 4 lines
Presumably we should also handle a
device_create_file()failure as well
- that is presently being silently ignored.
done.
I make 2 patch so that it will be easier to read.