Fix n800 build - Remove kernel config conditional declaration of TSC2005 device config structures

PATCH In review [email protected] 3 participants 6 messages May 25, 2008 – May 26, 2008

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

[email protected]

author

2008-05-25 08:45 UTC #0 lore raw

PATCH 1/1 Fix n800 build - Remove kernel config conditional declaration of TSC2005 device config structures

Signed-off-by Nick Loeve <[email protected]>

---
 arch/arm/mach-omap2/board-n800.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/board-n800.c +0 -2

index ae85c2c..f902482 100644
@@ -372,7 +372,6 @@ static struct omap2_mcspi_device_config cx3110x_mcspi_config = {
 	.single_channel = 1,
 };
 
-#ifdef CONFIG_TOUCHSCREEN_TSC2005
 static struct tsc2005_platform_data tsc2005_config = {
 	.reset_gpio = 94,
 	.dav_gpio = 106

@@ -382,7 +381,6 @@ static struct omap2_mcspi_device_config tsc2005_mcspi_config = {
 	.turbo_mode	= 0,
 	.single_channel = 1,
 };
-#endif
 
 static struct spi_board_info n800_spi_board_info[] __initdata = {
 	{

Signature · 1 line

1.5.5.1

nick loeve

author

2008-05-25 08:49 UTC #1 lore raw

Hi,

This patch is if i do not build with CONFIG_TOUCHSCREEN_TSC2005 enabled.

I am trying to build a bare basics kernel for the n800, and it seems that arch/arm/mach-omap2/board-n800.c could do with some rearrangement to not declare/use structures for devices not present in a n800 and vice versa for the n810.

Im fairly newb, but could have a go at it, if it is deemed a good use of time.

Cheers

Quoted 30 lines · On Sun, May 25, 2008 at 10:45 AM, <[email protected]> wrote:

Signed-off-by Nick Loeve <[email protected]>

---
 arch/arm/mach-omap2/board-n800.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/board-n800.c +0 -3

index ae85c2c..f902482 100644
@@ -372,7 +372,6 @@ static struct omap2_mcspi_device_config cx3110x_mcspi_config = {
       .single_channel = 1,
 };
 
-#ifdef CONFIG_TOUCHSCREEN_TSC2005
 static struct tsc2005_platform_data tsc2005_config = {
       .reset_gpio = 94,
       .dav_gpio = 106

@@ -382,7 +381,6 @@ static struct omap2_mcspi_device_config tsc2005_mcspi_config = {
       .turbo_mode     = 0,
       .single_channel = 1,
 };
-#endif
 
 static struct spi_board_info n800_spi_board_info[] __initdata = {
       {
--

1.5.5.1

Signature · 1 line

Nick Loeve

Igor Stoppa

2008-05-25 12:44 UTC #2 lore raw

Hi,

Quoted 5 lines · ext nick loeve

Hi,
This patch is if i do not build with CONFIG_TOUCHSCREEN_TSC2005 enabled.
I am trying to build a bare basics kernel for the n800,

depending on what exactly is your goal, you might discover that it is not reachable: the bootloader does lots of initializations (lcd, usb, ...) that are reset by the respective drivers. In case you don't include those drivers, you can kiss goodbye to working power management.

The only way would be to create a section in the board file which groups all the resets and executes them regardless of the respective driver being enabled.

The bootrom also does initialize the UART.

Signature · 6 lines

Cheers, Igor

---

Igor Stoppa
Nokia Devices R&D - Helsinki

nick loeve

author

2008-05-26 06:42 UTC #3 lore raw

Hi Igor,

Quoted 5 lines · Igor Stoppa

Hi,
Quoted 2 lines · ext nick loeve
Hi,

Quoted 8 lines

Quoted 3 lines
This patch is if i do not build with CONFIG_TOUCHSCREEN_TSC2005 enabled.
I am trying to build a bare basics kernel for the n800,
depending on what exactly is your goal, you might discover that it is not reachable: the bootloader does lots of initializations (lcd, usb, ...) that are reset by the respective drivers. In case you don't include those drivers, you can kiss goodbye to working power management.

Ok. I was thinking there may be issues similar to that, but for now im just experimenting. I am also trying to get qemu system emulation working with a recent linux-omap kernel for the mamona project, which is how i started on this in the first place.

Quoted 5 lines

The only way would be to create a section in the board file which groups all the resets and executes them regardless of the respective driver being enabled.

Hmmm sounds like a challenge :) Ill take a look.

Thanks for the info

Cheers

Quoted 10 lines

The bootrom also does initialize the UART.
--
Cheers, Igor
---
Igor Stoppa
Nokia Devices R&D - Helsinki

Signature · 1 line

Nick Loeve

Felipe Balbi

2008-05-25 08:53 UTC #4 lore raw

In reply to [email protected]

Quoted 19 lines · On Sun, May 25, 2008 at 10:45:41AM +0200, [email protected] wrote:

Signed-off-by Nick Loeve <[email protected]>

---
 arch/arm/mach-omap2/board-n800.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/board-n800.c +0 -1

index ae85c2c..f902482 100644
@@ -372,7 +372,6 @@ static struct omap2_mcspi_device_config cx3110x_mcspi_config = {
 	.single_channel = 1,
 };
 
-#ifdef CONFIG_TOUCHSCREEN_TSC2005
 static struct tsc2005_platform_data tsc2005_config = {
 	.reset_gpio = 94,
 	.dav_gpio = 106

arch/arm/mach-omap2/board-n800.c static struct omap2_mcspi_device_config tsc2005_mcspi_config = { · line 385

Quoted 4 lines

arch/arm/mach-omap2/board-n800.c +0 -1

@@ -382,7 +381,6 @@ static struct omap2_mcspi_device_config tsc2005_mcspi_config = {
 	.turbo_mode	= 0,
 	.single_channel = 1,
 };
-#endif

This one i think it should remain the way it is. I'm wondering if it'll generate warnings in any way.

Could you try something?

Remove also the CONFIG_TOUCHSCREEN_TSC2301. And try building n800/n810, n800-only and n810-only. Also flash and boot test them, please.

If you don't get any warnings and no errors. I'm ok with this patch when you remove also the TSC2301 ifdef.

Signature · 5 lines

Best Regards,

Felipe Balbi
[email protected]
http://blog.felipebalbi.com

nick loeve

author

2008-05-26 06:35 UTC #5 lore raw

Hi Felipe

Quoted 15 lines · Felipe Balbi

Quoted 14 lines · On Sun, May 25, 2008 at 10:45:41AM +0200, [email protected] wrote:
Signed-off-by Nick Loeve <[email protected]>
---
 arch/arm/mach-omap2/board-n800.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/board-n800.c +0 -0
index ae85c2c..f902482 100644
@@ -372,7 +372,6 @@ static struct omap2_mcspi_device_config cx3110x_mcspi_config = {
      .single_channel = 1,
 };
 

Quoted 12 lines

arch/arm/mach-omap2/board-n800.c static struct omap2_mcspi_device_config tsc2005_mcspi_config = { · line 385
Quoted 9 lines
arch/arm/mach-omap2/board-n800.c +0 -2
-#ifdef CONFIG_TOUCHSCREEN_TSC2005
 static struct tsc2005_platform_data tsc2005_config = {
      .reset_gpio = 94,
      .dav_gpio = 106
@@ -382,7 +381,6 @@ static struct omap2_mcspi_device_config tsc2005_mcspi_config = {
      .turbo_mode     = 0,
      .single_channel = 1,
 };
-#endif
This one i think it should remain the way it is. I'm wondering if it'll generate warnings in any way.

I didn't notice any, but then i didn't test it much...

Quoted 8 lines

Could you try something?
Remove also the CONFIG_TOUCHSCREEN_TSC2301. And try building n800/n810, n800-only and n810-only. Also flash and boot test them, please.
If you don't get any warnings and no errors. I'm ok with this patch when you remove also the TSC2301 ifdef.

Sure, i can try. I only have a n800 to test on though... but i will try anyway. Pretty busy this week, but i will get to it.

Cheers

Quoted 8 lines

--
Best Regards,
Felipe Balbi
[email protected]
http://blog.felipebalbi.com

Signature · 1 line

Nick Loeve