Skip to contentSkip to conversation

: check CONFIG_GENERIC_HARDIRQS for request/free_irq in interrupt.h

Patch/RFC Christian Borntraeger 3 participants 4 messages May 29, 2008 – May 30, 2008

lore
Share & tools
lore
#0 lore raw

I currently try to evaluate virtio_console for kvm on s390 and got the following problem:

virtio_console uses hvc_alloc with irq=0. That means, register_irq and free_irq are never called by hvc_console.c, but the linker will still complain about unknown references to free_irq and request_irq.

As the whole kernel/irq folder depends on CONFIG_GENERIC_HARDIRQS it seems consistent to declare all functions from kernel/irq only if CONFIG_GENERIC_HARDIRQS is set. Otherwise we can use empty functions.

This patch does that for register_irq and free_irq.

Comments?

CC Ingo Molnar <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Martin Schwidefsky <[email protected]>
---
 include/linux/interrupt.h |   13 +++++++++++++
 1 file changed, 13 insertions(+)
include/linux/interrupt.h +13 -0
Index: linux-2.6/include/linux/interrupt.h
===================================================================
@@ -69,9 +69,22 @@ struct irqaction {
 };
 
 extern irqreturn_t no_action(int cpl, void *dev_id);
+
+#ifdef CONFIG_GENERIC_HARDIRQS
 extern int __must_check request_irq(unsigned int, irq_handler_t handler,
 		       unsigned long, const char *, void *);
 extern void free_irq(unsigned int, void *);
+#else
+static inline int request_irq(unsigned int irq, irq_handler_t handler,
+		unsigned long irqflags, const char *devname, void *dev_id)
+{
+	return -EINVAL;
+}
+
+static inline void free_irq(unsigned int irq, void *dev_id)
+{
+}
+#endif
 
 struct device;
 
#1 lore raw
Quoted 7 lines · Christian Borntraeger

I currently try to evaluate virtio_console for kvm on s390 and got the following problem:

virtio_console uses hvc_alloc with irq=0. That means, register_irq and free_irq are never called by hvc_console.c, but the linker will still complain about unknown references to free_irq and request_irq.

Quoted 7 lines

As the whole kernel/irq folder depends on CONFIG_GENERIC_HARDIRQS it seems consistent to declare all functions from kernel/irq only if CONFIG_GENERIC_HARDIRQS is set. Otherwise we can use empty functions.

This patch does that for register_irq and free_irq.

Comments?

Please don't. So far whenever the linker complained about the missing register_irq/free_irq functions it has been a bug in a Kconfig file. We should not silently accept code that requires the concept of an irq-line when there is no such thing on a s390.

Signature · 4 lines
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.
#2 lore raw

Am Donnerstag, 29. Mai 2008 schrieb Martin Schwidefsky:

Quoted 12 lines · Christian Borntraeger
Quoted 11 lines

I currently try to evaluate virtio_console for kvm on s390 and got the following problem:

virtio_console uses hvc_alloc with irq=0. That means, register_irq and free_irq are never called by hvc_console.c, but the linker will still complain about unknown references to free_irq and request_irq.

As the whole kernel/irq folder depends on CONFIG_GENERIC_HARDIRQS it seems consistent to declare all functions from kernel/irq only if CONFIG_GENERIC_HARDIRQS is set. Otherwise we can use empty functions.

Quoted 8 lines
Quoted 3 lines

This patch does that for register_irq and free_irq.

Comments?

Please don't. So far whenever the linker complained about the missing register_irq/free_irq functions it has been a bug in a Kconfig file. We should not silently accept code that requires the concept of an irq-line when there is no such thing on a s390.

Ok, convinced.

I will look if I can modify virtio_console to get rid of hvc_console. Reading all the comments, it appears that Rusty is not really happy with all the dependencies/limitations that hvc_console brings to virtio_console.

Rusty, be prepared.... ;-)

Christian

#3 lore raw
Quoted 24 lines · On Friday 30 May 2008 04:32:58 Christian Borntraeger wrote:

Am Donnerstag, 29. Mai 2008 schrieb Martin Schwidefsky:

Quoted 12 lines · Christian Borntraeger
Quoted 11 lines

I currently try to evaluate virtio_console for kvm on s390 and got the following problem:

virtio_console uses hvc_alloc with irq=0. That means, register_irq and free_irq are never called by hvc_console.c, but the linker will still complain about unknown references to free_irq and request_irq.

As the whole kernel/irq folder depends on CONFIG_GENERIC_HARDIRQS it seems consistent to declare all functions from kernel/irq only if CONFIG_GENERIC_HARDIRQS is set. Otherwise we can use empty functions.

Quoted 8 lines
Quoted 3 lines

This patch does that for register_irq and free_irq.

Comments?

Please don't. So far whenever the linker complained about the missing register_irq/free_irq functions it has been a bug in a Kconfig file. We should not silently accept code that requires the concept of an irq-line when there is no such thing on a s390.

Ok, convinced.

Quoted 7 lines

I will look if I can modify virtio_console to get rid of hvc_console. Reading all the comments, it appears that Rusty is not really happy with all the dependencies/limitations that hvc_console brings to virtio_console.

Rusty, be prepared.... ;-)

Christian

OK, my plan was to at least allow the hook of notifiers in hvc_console, rather than relying on interrupts or nothing. Then expose "use interrupt to notify" and "use a backoff timer to notify" helpers and let the caller hook one up.

But it was a vague plan which may become unrecognisable when meeting reality...

Cheers,
Rusty.