powerpc: use get/put_endian helpers
Subsystems (2)
PATCH 2/37 powerpc: use get/put_endian helpers
Signed-off-by Harvey Harrison <[email protected]>
--- arch/powerpc/sysdev/qe_lib/qe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/sysdev/qe_lib/qe.c +1 -1
@@ -528,7 +528,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware) }/* Validate the CRC */ - crc =be32_to_cpu (*(__be32 *)((void *)firmware + calc_size)); + crc =get_be32 ((__be32 *)((void *)firmware + calc_size));if (crc !=crc32 (0 , firmware, calc_size)) {printk (KERN_ERR "qe-firmware: firmware CRC is invalid\n" );return -EIO ;
Signature · 1 line
1.5.6.rc0.277.g804cf
Quoted 2 lines · Harvey Harrison
Signed-off-by Harvey Harrison <[email protected]>---
Somewhere in this series of patches there should be a patch description that tells us why we're making all these changes. I don't know what the motivation for them is and I don't see it spelled out anywhere. If/when these patches go into git there needs to be at least one of the commits whose description records the motivation for posterity.
Paul.