Skip to contentSkip to conversation

powerpc: use get/put_endian helpers

PATCH In review Harvey Harrison 2 participants 2 messages May 29, 2008 – May 30, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/37 powerpc: use get/put_endian helpers

---
 arch/powerpc/sysdev/qe_lib/qe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/sysdev/qe_lib/qe.c +1 -1
index cff550e..7981205 100644
@@ -528,7 +528,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
 	}
 
 	/* Validate the CRC */
-	crc = be32_to_cpu(*(__be32 *)((void *)firmware + calc_size));
+	crc = get_be32((__be32 *)((void *)firmware + calc_size));
 	if (crc != crc32(0, firmware, calc_size)) {
 		printk(KERN_ERR "qe-firmware: firmware CRC is invalid\n");
 		return -EIO;
Signature · 1 line
1.5.6.rc0.277.g804cf
#1 lore raw
Quoted 2 lines · Harvey Harrison

---

Somewhere in this series of patches there should be a patch description that tells us why we're making all these changes. I don't know what the motivation for them is and I don't see it spelled out anywhere. If/when these patches go into git there needs to be at least one of the commits whose description records the motivation for posterity.

Paul.