acpi: fix sparse const errors
PATCH 1/1 acpi: fix sparse const errors
In this case we want a constant pointer to constant chars:drivers/misc/thinkpad_acpi.c:3824:19: error: Just how const do you want this type to be?
Like the error says.drivers/misc/thinkpad_acpi.c:3863:19: error: Just how const do you want this type to be? drivers/misc/thinkpad_acpi.c:3864:19: error: Just how const do you want this type to be? drivers/misc/thinkpad_acpi.c:3865:19: error: Just how const do you want this type to be? drivers/misc/thinkpad_acpi.c:3866:19: error: Just how const do you want this type to be?
--- drivers/misc/thinkpad_acpi.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/misc/thinkpad_acpi.c +5 -5
@@ -3821,7 +3821,7 @@ TPACPI_HANDLE(led, ec, "SLED", /* 570 */#define TPACPI_LED_NUMLEDS 8static struct tpacpi_led_classdev *tpacpi_leds;static enum led_status_t tpacpi_led_state_cache[TPACPI_LED_NUMLEDS ]; -static const char const *tpacpi_led_names[TPACPI_LED_NUMLEDS ] = { +static const char *const tpacpi_led_names[TPACPI_LED_NUMLEDS ] = {/* there's a limit of 19 chars + NULL before 2.6.26 */ "tpacpi::power" ,"tpacpi:orange:batt" ,
@@ -3860,10 +3860,10 @@ static int led_get_status(unsigned int led)static int led_set_status (unsigned int led,enum led_status_t ledstatus) {/* off, on, blink. Index is led_status_t */ -static const int const led_sled_arg1[] = {0 ,1 ,3 }; -static const int const led_exp_hlbl[] = {0 ,0 ,1 };/* led# * */ -static const int const led_exp_hlcl[] = {0 ,1 ,1 };/* led# * */ -static const int const led_led_arg1[] = {0 ,0x80 ,0xc0 }; +static const int led_sled_arg1[] = {0 ,1 ,3 }; +static const int led_exp_hlbl[] = {0 ,0 ,1 };/* led# * */ +static const int led_exp_hlcl[] = {0 ,1 ,1 };/* led# * */ +static const int led_led_arg1[] = {0 ,0x80 ,0xc0 };int rc =0 ;
Signature · 1 line
1.5.6.rc0.277.g804cf
Quoted 10 lines · Harvey Harrison
In this case we want a constant pointer to constant chars:
drivers/misc/thinkpad_acpi.c:3824:19: error: Just how const do you want this type to be?Like the error says.
drivers/misc/thinkpad_acpi.c:3863:19: error: Just how const do you want this type to be?drivers/misc/thinkpad_acpi.c:3864:19: error: Just how const do you want this type to be?drivers/misc/thinkpad_acpi.c:3865:19: error: Just how const do you want this type to be?drivers/misc/thinkpad_acpi.c:3866:19: error: Just how const do you want this type to be?Signed-off-by Harvey Harrison <[email protected]>
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh