ext4: remove redundant code in ext4_fill_super()
PATCH 1/1 ext4: remove redundant code in ext4_fill_super()
The previous sb_min_blocksize() has already set the block size.
This piece of code was introduced in commit:
afc7cbca5bfd556c3e12d3acefbee5ab0cbd4670 (ext4: Support large blocksize up to PAGESIZE)
And it should be a mistake.
Signed-off-by Li Zefan <[email protected]>
--- fs/ext4/super.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
fs/ext4/super.c +0 -4
@@ -1843,11 +1843,6 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent) goto out_fail; } -if (!sb_set_blocksize (sb, blocksize)) { -printk (KERN_ERR "EXT4-fs: bad blocksize %d.\n" , blocksize); - goto out_fail; - }
Quoted 7 lines · Li Zefan
The previous
sb_min_blocksize()has already set the block size.This piece of code was introduced in commit:
afc7cbca5bfd556c3e12d3acefbee5ab0cbd4670 (ext4: Support large blocksize up to PAGESIZE)And it should be a mistake.
Signed-off-by Mingming Cao <[email protected]>
Added to ext4 patch queue http://repo.or.cz/w/ext4-patch-queue.git
Quoted 21 lines
Signed-off-by Li Zefan <[email protected]>--- fs/ext4/super.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)fs/ext4/super.c +0
-5@@ -1843,11 +1843,6 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent) goto out_fail; } -if (!sb_set_blocksize (sb, blocksize)) { -printk (KERN_ERR "EXT4-fs: bad blocksize %d.\n" , blocksize); - goto out_fail; - } -/* * The ext4 superblock will not be buffer aligned for other than 1kB * block sizes. We need to calculate the offset from buffer start.