USB: isp1760: Assign resource fields before adding hcd

This fixes the bogus "io mem 0x00000000" message printed during driver init due to hcd->rsrc_start being assigned after the call to usb_add_hcd().

---
 drivers/usb/host/isp1760-hcd.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

index c9cec87..65aa5ec 100644
@@ -2207,14 +2207,14 @@ struct usb_hcd *isp1760_register(u64 res_start, u64 res_len, int irq,
 		goto err_put;
 	}
 
-	ret = usb_add_hcd(hcd, irq, irqflags);
-	if (ret)
-		goto err_unmap;
-
 	hcd->irq = irq;
 	hcd->rsrc_start = res_start;
 	hcd->rsrc_len = res_len;
 
+	ret = usb_add_hcd(hcd, irq, irqflags);
+	if (ret)
+		goto err_unmap;
+
 	return hcd;
 
 err_unmap:

1.5.4.4

I saw this and was wondering why it was correct in other places like /proc/iomem :)

This is a note to let you know that I've just added the patch titled

Subject: USB: isp1760: Assign resource fields before adding hcd

to my gregkh-2.6 tree. Its filename is

usb-isp1760-assign-resource-fields-before-adding-hcd.patch

This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/

From: Nate Case <[email protected]>
Date: Wed, 21 May 2008 16:28:20 -0500
Subject: USB: isp1760: Assign resource fields before adding hcd
To: Sebastian Siewior <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>, [email protected], linuxppc-dev <[email protected]>
Message-ID: <[email protected]>

This fixes the bogus "io mem 0x00000000" message printed during driver init due to hcd->rsrc_start being assigned after the call to usb_add_hcd().

---
 drivers/usb/host/isp1760-hcd.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

@@ -2207,14 +2207,14 @@ struct usb_hcd *isp1760_register(u64 res
 		goto err_put;
 	}
 
-	ret = usb_add_hcd(hcd, irq, irqflags);
-	if (ret)
-		goto err_unmap;
-
 	hcd->irq = irq;
 	hcd->rsrc_start = res_start;
 	hcd->rsrc_len = res_len;
 
+	ret = usb_add_hcd(hcd, irq, irqflags);
+	if (ret)
+		goto err_unmap;
+
 	return hcd;
 
 err_unmap:

Patches currently in gregkh-2.6 which might be from [email protected] are

usb.current/usb-isp1760-assign-resource-fields-before-adding-hcd.patch