Skip to contentSkip to conversation

radeonfb: Revert "Fix radeon DDC regression"

PATCH In review Jean Delvare 3 participants 4 messages Jun 6, 2008 – Jul 31, 2008 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 radeonfb: Revert "Fix radeon DDC regression"

The bug was in fb_ddc and was fixed by commit b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk) so the workaround in radeonfb can be removed now.

---
 drivers/video/aty/radeon_i2c.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/video/aty/radeon_i2c.c +0 -4
@@ -139,12 +139,8 @@ void radeon_delete_i2c_busses(struct rad
 int radeon_probe_i2c_connector(struct radeonfb_info *rinfo, int conn,
 			       u8 **out_edid)
 {
-	u32 reg = rinfo->i2c[conn-1].ddc_reg;
 	u8 *edid;
 
-	OUTREG(reg, INREG(reg) &
-			~(VGA_DDC_DATA_OUTPUT | VGA_DDC_CLK_OUTPUT));
-
 	edid = fb_ddc_read(&rinfo->i2c[conn-1].adapter);
 
 	if (out_edid)
Signature · 7 lines
Jean Delvare

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
#1 lore raw
Quoted 6 lines · Jean Delvare

The bug was in fb_ddc and was fixed by commit b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk) so the workaround in radeonfb can be removed now.

---

I need to verify that on my Apple monitor which would switch off if that is wrong. Will try to do that this week-end. Without news from me next week, then just commit the bloody thing :-)

Cheers,
Ben.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

#2 lore raw
Quoted 5 lines · On Sat, 07 Jun 2008 09:21:51 +1000 Benjamin Herrenschmidt…
Quoted 4 lines · Jean Delvare

The bug was in fb_ddc and was fixed by commit b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk) so the workaround in radeonfb can be removed now.

Quoted 7 lines
Quoted 2 lines

---

I need to verify that on my Apple monitor which would switch off if that is wrong. Will try to do that this week-end. Without news from me next week, then just commit the bloody thing :-)

I queued this for 2.6.28.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

#3 lore raw
Quoted 10 lines · Andrew Morton
Quoted 8 lines · On Sat, 07 Jun 2008 09:21:51 +1000 Benjamin Herrenschmidt…
Quoted 6 lines · Jean Delvare

The bug was in fb_ddc and was fixed by commit b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk) so the workaround in radeonfb can be removed now.

---

Quoted 6 lines
Quoted 4 lines

I need to verify that on my Apple monitor which would switch off if that is wrong. Will try to do that this week-end. Without news from me next week, then just commit the bloody thing :-)

I queued this for 2.6.28.

Ok. The monitor that was having problem is hooked on some other stuff and I don't have the radeon machine in the same building so unless people complain, I think this patch will do.

Ben.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/