crypto: testmgr - disallow certain DRBG hash functions in FIPS mode
Subsystems (2)
PATCH 1/1 crypto: testmgr - disallow certain DRBG hash functions in FIPS mode
According to FIPS 140-3 IG, section D.R "Hash Functions Acceptable for Use in the SP 800-90A DRBGs", modules certified after May 16th, 2023 must not support the use of: SHA-224, SHA-384, SHA512-224, SHA512-256, SHA3-224, SHA3-384. Disallow HMAC and HASH DRBGs using SHA-384 in FIPS mode.
---
Some details:
The following DRBG algos are defined in testmgr.c as of now:
drbg_{no,}pr_ctr_aes128
drbg_{no,}pr_ctr_aes192
drbg_{no,}pr_ctr_aes256
drbg_{no,}pr_hmac_sha1
drbg_{no,}pr_hmac_sha256
drbg_{no,}pr_hmac_sha384 (disallow)
drbg_{no,}pr_hmac_sha512
drbg_{no,}pr_sha1
drbg_{no,}pr_sha256
drbg_{no,}pr_sha384 (disallow)
drbg_{no,}pr_sha512
Marked DRBGs should be disallowed in FIPS mode according to the requirements above.
--- crypto/testmgr.c | 4 ---- 1 file changed, 4 deletions(-)
crypto/testmgr.c +0 -4
@@ -4782,7 +4782,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_nopr_hmac_sha256 test */ .alg = "drbg_nopr_hmac_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_nopr_hmac_sha512",
@@ -4805,7 +4804,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_nopr_sha256 test */ .alg = "drbg_nopr_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_nopr_sha512",
@@ -4841,7 +4839,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_pr_hmac_sha256 test */ .alg = "drbg_pr_hmac_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_pr_hmac_sha512",
@@ -4861,7 +4858,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_pr_sha256 test */ .alg = "drbg_pr_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_pr_sha512",
Signature · 1 line
2.39.0
Am Dienstag, 17. Januar 2023, 18:20:06 CET schrieb Vladis Dronov:
Hi Vladis,
Quoted 7 lines
According to FIPS 140-3 IG, section D.R "Hash Functions Acceptable for Use in the SP 800-90A DRBGs", modules certified after May 16th, 2023 must not support the use of: SHA-224, SHA-384, SHA512-224, SHA512-256, SHA3-224, SHA3-384. Disallow HMAC and HASH DRBGs using SHA-384 in FIPS mode.
Signed-off-by Vladis Dronov <[email protected]>
Thank you very much for the patch!
Quoted 54 lines
---
Some details:The following DRBG algos are defined in
testmgr.cas of now:drbg_{no,}pr_ctr_aes128
drbg_{no,}pr_ctr_aes192
drbg_{no,}pr_ctr_aes256drbg_{no,}pr_hmac_sha1
drbg_{no,}pr_hmac_sha256
drbg_{no,}pr_hmac_sha384 (disallow)
drbg_{no,}pr_hmac_sha512drbg_{no,}pr_sha1
drbg_{no,}pr_sha256
drbg_{no,}pr_sha384 (disallow)
drbg_{no,}pr_sha512Marked DRBGs should be disallowed in FIPS mode according to the requirements above.
--- crypto/testmgr.c | 4 ---- 1 file changed, 4 deletions(-)crypto/testmgr.c +0
-3@@ -4782,7 +4782,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_nopr_hmac_sha256 test */ .alg = "drbg_nopr_hmac_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_nopr_hmac_sha512",@@ -4805,7 +4804,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_nopr_sha256 test */ .alg = "drbg_nopr_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_nopr_sha512",@@ -4841,7 +4839,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_pr_hmac_sha256 test */ .alg = "drbg_pr_hmac_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_pr_hmac_sha512",
crypto/testmgr.c static const struct alg_test_desc alg_test_descs[] = { · line 4863
Quoted 7 lines
crypto/testmgr.c +0
-1@@ -4861,7 +4858,6 @@ static const struct alg_test_desc alg_test_descs[] = { }, {/* covered by drbg_pr_sha256 test */ .alg = "drbg_pr_sha384", - .fips_allowed = 1, .test = alg_test_null, }, { .alg = "drbg_pr_sha512",
Ciao
Stephan
Herbert Xu
maintainerQuoted 26 lines · Vladis Dronov
According to FIPS 140-3 IG, section D.R "Hash Functions Acceptable for Use in the SP 800-90A DRBGs", modules certified after May 16th, 2023 must not support the use of: SHA-224, SHA-384, SHA512-224, SHA512-256, SHA3-224, SHA3-384. Disallow HMAC and HASH DRBGs using SHA-384 in FIPS mode.
Signed-off-by Vladis Dronov <[email protected]>---
Some details:The following DRBG algos are defined in
testmgr.cas of now:drbg_{no,}pr_ctr_aes128
drbg_{no,}pr_ctr_aes192
drbg_{no,}pr_ctr_aes256drbg_{no,}pr_hmac_sha1
drbg_{no,}pr_hmac_sha256
drbg_{no,}pr_hmac_sha384 (disallow)
drbg_{no,}pr_hmac_sha512drbg_{no,}pr_sha1
drbg_{no,}pr_sha256
drbg_{no,}pr_sha384 (disallow)
drbg_{no,}pr_sha512
Quoted 5 lines
Marked DRBGs should be disallowed in FIPS mode according to the requirements above.
--- crypto/testmgr.c | 4 ---- 1 file changed, 4 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt