Skip to contentSkip to conversation

a pair of small ACPI patches for 2.6.26-rc6

PATCH New Len Brown 1 participant 3 messages Jun 20, 2008 ACPI

lore
Share & tools
lore

Len Brown

author reviewer
#0 lore raw

these two going up now.
Please let me know if I miss anything
that seems appropriate for rc6.

thanks,
-Len

author reviewer
#1 lore raw

PATCH 1/2 ACPI Exception (video-1721): UNKNOWN_STATUS_CODE, Cant attach device

From: Zhang Rui <[email protected]>

The child of a video bus device is not alway a video device. It should be a warn message rather than an exception here.
http://bugzilla.kernel.org/show_bug.cgi?id=9761

---
 drivers/acpi/video.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/acpi/video.c +2 -1
index 5e5dda3..d089c45 100644
@@ -1713,7 +1713,8 @@ acpi_video_bus_get_devices(struct acpi_video_bus *video,
 
 		status = acpi_video_bus_get_one_device(dev, video);
 		if (ACPI_FAILURE(status)) {
-			ACPI_EXCEPTION((AE_INFO, status, "Cant attach device"));
+			ACPI_DEBUG_PRINT((ACPI_DB_WARN,
+					"Cant attach device"));
 			continue;
 		}
 	}
Signature · 1 line
1.5.6
author reviewer
#2 lore raw

PATCH 2/2 ACPI: no AC status notification

In reply to Len Brown

From: Len Brown <[email protected]>

http://bugzilla.kernel.org/show_bug.cgi?id=10695

---
 drivers/acpi/ac.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
drivers/acpi/ac.c +3 -5
index 5b73f6a..831883b 100644
@@ -233,6 +233,9 @@ static void acpi_ac_notify(acpi_handle handle, u32 event, void *data)
 
 	device = ac->device;
 	switch (event) {
+	default:
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+				  "Unsupported event [0x%x]\n", event));
 	case ACPI_AC_NOTIFY_STATUS:
 	case ACPI_NOTIFY_BUS_CHECK:
 	case ACPI_NOTIFY_DEVICE_CHECK:
@@ -244,11 +247,6 @@ static void acpi_ac_notify(acpi_handle handle, u32 event, void *data)
 #ifdef CONFIG_ACPI_SYSFS_POWER
 		kobject_uevent(&ac->charger.dev->kobj, KOBJ_CHANGE);
 #endif
-		break;
-	default:
-		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
-				  "Unsupported event [0x%x]\n", event));
-		break;
 	}
 
 	return;
Signature · 1 line
1.5.6