Skip to contentSkip to conversation

Ambiguous dupe in libusual device list

DISCUSSION Ben Collins 2 participants 2 messages Jun 26, 2008

lore
Share & tools
lore
#0 lore raw

In unusual_devs.h, there are these two entries:

#ifdef CONFIG_USB_STORAGE_DATAFAB
/* Submitted by Olaf Hering <[email protected]> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
"Datafab Systems, Inc.",
"USB to CF + SM Combo (LC1)",
US_SC_SCSI, US_PR_DATAFAB, NULL,
0 ),
#endif
#ifdef CONFIG_USB_STORAGE_SDDR55
/* SM part - aeb <[email protected]> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
"Datafab Systems, Inc.",
"USB to CF + SM Combo (LC1)",
US_SC_SCSI, US_PR_SDDR55, NULL,
US_FL_SINGLE_LUN ),
#endif

If I'm not mistaken (and because libusual is pretty well abstracted, I might be) this is an ambiguous dupe that isn't resolved with any checking (IOW, the second entry is likely never used), at least when both config options are enabled.

If that's not the case, then maybe a comment would be in order? If the case is that these two options should not be enabled at the same time, then perhaps some Kconfig magic is required.

#1 lore raw
Quoted 6 lines · Ben Collins

In unusual_devs.h, there are these two entries:

#ifdef CONFIG_USB_STORAGE_DATAFAB
/* Submitted by Olaf Hering <[email protected]> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,

Quoted 8 lines

#ifdef CONFIG_USB_STORAGE_SDDR55
/* SM part - aeb <[email protected]> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,

If I'm not mistaken (and because libusual is pretty well abstracted, I might be) this is an ambiguous dupe that isn't resolved with any checking (IOW, the second entry is likely never used), at least when both config options are enabled.

Reading the code, it looks like it's a bit more complex than that.

The first entry enables use of a driver (if it's compiled it) which can drive both slots on a dual-slot device.

The first entry enables use of a driver (if it's compiled it) which can only drive one slot on a dual-slot device.

This is really the type of thing which shows that we need some sort of semi-generic "preference" mechanism for driver binding...

Matt

Signature · 7 lines
Matthew Dharm                              Home: [email protected] 
Maintainer, Linux USB Mass Storage Driver

M:  No, Windows doesn't have any nag screens.
C:  Then what are those blue and white screens I get every day?
					-- Mike and Cobb
User Friendly, 1/4/1999