Skip to contentSkip to conversation

x86/pci: Removing pci-y in Makefile

PATCH In review Robert Richter 2 participants 3 messages Jul 11, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pci: Removing pci-y in Makefile

---
 arch/x86/pci/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
arch/x86/pci/Makefile +6 -6
index e515e8d..28451f4 100644
@@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG)	+= mmconfig_$(BITS).o direct.o mmconfig-shared.o
 obj-$(CONFIG_PCI_DIRECT)	+= direct.o
 obj-$(CONFIG_PCI_OLPC)		+= olpc.o
 
-pci-y				:= fixup.o
-pci-$(CONFIG_ACPI)		+= acpi.o
-pci-y				+= legacy.o irq.o
+obj-y				+= fixup.o
+obj-$(CONFIG_ACPI)		+= acpi.o
+obj-y				+= legacy.o irq.o
 
-pci-$(CONFIG_X86_VISWS)		+= visws.o
+obj-$(CONFIG_X86_VISWS)		+= visws.o
 
-pci-$(CONFIG_X86_NUMAQ)		+= numa.o
+obj-$(CONFIG_X86_NUMAQ)		+= numa.o
 
-obj-y				+= $(pci-y) common.o early.o
+obj-y				+= common.o early.o
 obj-y				+= amd_bus.o
Signature · 1 line
1.5.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Robert Richter
---
 arch/x86/pci/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
arch/x86/pci/Makefile +0 -0
index e515e8d..28451f4 100644

arch/x86/pci/Makefile obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o · line 8

Quoted 7 lines
arch/x86/pci/Makefile +1 -3
@@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG)	+= mmconfig_$(BITS).o direct.o mmconfig-shared.o
 obj-$(CONFIG_PCI_DIRECT)	+= direct.o
 obj-$(CONFIG_PCI_OLPC)		+= olpc.o
 
-pci-y				:= fixup.o
-pci-$(CONFIG_ACPI)		+= acpi.o
-pci-y				+= legacy.o irq.o
+obj-y				+= fixup.o

Hi Robert.
Now I see the full patch I understood your comment. I had missed that there was assignments above fixup.o

Sam

#2 lore raw
Quoted 15 lines · Sam Ravnborg
Quoted 14 lines · Robert Richter
---
 arch/x86/pci/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
arch/x86/pci/Makefile +0 -0
index e515e8d..28451f4 100644
@@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG)	+= mmconfig_$(BITS).o direct.o mmconfig-shared.o
 obj-$(CONFIG_PCI_DIRECT)	+= direct.o
 obj-$(CONFIG_PCI_OLPC)		+= olpc.o
 
Quoted 8 lines

arch/x86/pci/Makefile obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o · line 8

Quoted 4 lines
arch/x86/pci/Makefile +1 -3
-pci-y				:= fixup.o
-pci-$(CONFIG_ACPI)		+= acpi.o
-pci-y				+= legacy.o irq.o
+obj-y				+= fixup.o

Hi Robert.
Now I see the full patch I understood your comment. I had missed that there was assignments above fixup.o

Yes, it was not the first entry.

-Robert

Quoted 6 lines

Sam

Signature · 3 lines
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]