Skip to contentSkip to conversation

Fix collateral damage to top level Makefile

PATCH In review Grant Likely 5 participants 6 messages Jul 17, 2008 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix collateral damage to top level Makefile

From: Grant Likely <[email protected]>

The patch named "powerpc/mpc5121: Add clock driver", also contained an unrelated and bogus change to the top-level makefile. This patch backs out the bad bit.

SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)

---

If the maintainer who picked up this patch (Grant Likely) had done his job, this cack-up never would have happened. Why do we still have to deal with such sloppy individuals?

Ben/Linus; I assume one of you will want to pick this up soonish? Otherwise, I'll add it to my tree and it will be part of my next pull request.

g.

 Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Makefile +0 -1
index 1564577..6192922 100644
@@ -1,4 +1,3 @@
-FRED=42
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 26
#1 lore raw
Quoted 6 lines · Grant Likely

From: Grant Likely <[email protected]>

The patch named "powerpc/mpc5121: Add clock driver", also contained an unrelated and bogus change to the top-level makefile. This patch backs out the bad bit.

Quoted 9 lines

SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)

---

If the maintainer who picked up this patch (Grant Likely) had done his job, this cack-up never would have happened. Why do we still have to deal with such sloppy individuals?

I think the more important question is why the hell would anyone put that in a Makefile, ever? ;-)

#2 lore raw
Quoted 12 lines · Paul Mundt
Quoted 11 lines · Grant Likely

From: Grant Likely <[email protected]>

The patch named "powerpc/mpc5121: Add clock driver", also contained an unrelated and bogus change to the top-level makefile. This patch backs out the bad bit.

SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)

---

Quoted 6 lines
Quoted 4 lines

If the maintainer who picked up this patch (Grant Likely) had done his job, this cack-up never would have happened. Why do we still have to deal with such sloppy individuals?

I think the more important question is why the hell would anyone put that in a Makefile, ever? ;-)

Well, it's partially my fault for not spotting it when pulling in Grant's git and pushing out to Linus.

Anyway, it's a mistake, shit happens, I doubt Grant will do that one twice :-)

Cheers,
Ben.

#3 lore raw
Quoted 17 lines · Benjamin Herrenschmidt
Quoted 16 lines · Paul Mundt
Quoted 15 lines · Grant Likely

From: Grant Likely <[email protected]>

The patch named "powerpc/mpc5121: Add clock driver", also contained an unrelated and bogus change to the top-level makefile. This patch backs out the bad bit.

SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)

---

If the maintainer who picked up this patch (Grant Likely) had done his job, this cack-up never would have happened. Why do we still have to deal with such sloppy individuals?

Quoted 8 lines
Quoted 2 lines

I think the more important question is why the hell would anyone put that in a Makefile, ever? ;-)

Well, it's partially my fault for not spotting it when pulling in Grant's git and pushing out to Linus.

Anyway, it's a mistake, shit happens, I doubt Grant will do that one twice :-)

Oh come on, don't scare the guy more than he is - now he'll be staring frantically at each +-diff line before submitting :). And it's not like it's the end of the world, it's just that Fred has turned 42 or similar :)

P.S. If I only knew how such an innocent thing would destroy a man's life i never would've
reported it in the first place :). Sorry Grant.

Signature · 2 lines
Regards/Gruß,
Boris
#4 lore raw
Quoted 10 lines · Boris Petkov
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 1 line · Paul Mundt

On Thu, Jul 17, 2008 at 01:06:55AM -0600, Grant Likely wrote:

Well, it's partially my fault for not spotting it when pulling in Grant's git and pushing out to Linus.

Anyway, it's a mistake, shit happens, I doubt Grant will do that one twice :-)

Quoted 7 lines

Oh come on, don't scare the guy more than he is - now he'll be staring frantically at each +-diff line before submitting :). And it's not like it's the end of the world, it's just that Fred has turned 42 or similar :)

P.S. If I only knew how such an innocent thing would destroy a man's life i never would've
reported it in the first place :). Sorry Grant.

Heh, oh please, I've got a thicker skin that that. I appreciate the error being pointed out.

But Ben's right. That mistake will not happen again! :-)

Cheers,
g.

#5 lore raw
In reply to Grant Likely

Grant,

I owe you on this one. Sorry.

John

Quoted 36 lines · Grant Likely

From: Grant Likely <[email protected]>

The patch named "powerpc/mpc5121: Add clock driver", also contained an unrelated and bogus change to the top-level makefile. This patch backs out the bad bit.

SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)

---

If the maintainer who picked up this patch (Grant Likely) had done his job, this cack-up never would have happened. Why do we still have to deal with such sloppy individuals?

Ben/Linus; I assume one of you will want to pick this up soonish? Otherwise, I'll add it to my tree and it will be part of my next pull request.

g.

 Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Makefile +0 -1
index 1564577..6192922 100644
@@ -1,4 +1,3 @@
-FRED=42
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 26