Skip to contentSkip to conversation

x86: suppress sparse returning void warnings

PATCH Applied Harvey Harrison 3 participants 3 messages Jul 17, 2008 – Jul 18, 2008 Linux-next tree

lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 1/3 x86: suppress sparse returning void warnings

include/asm/paravirt.h:1404:2: warning: returning void-valued expression include/asm/paravirt.h:1414:2: warning: returning void-valued expression

Signed-off-by Harvey Harrison <[email protected]>

---
Appeared between next-20080716 and next-20080717

 include/asm-x86/paravirt.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-x86/paravirt.h +2 -2
index b2aba8f..27c9f22 100644
@@ -1401,7 +1401,7 @@ static inline int __raw_spin_is_contended(struct raw_spinlock *lock)
 
 static __always_inline void __raw_spin_lock(struct raw_spinlock *lock)
 {
-	return PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
+	PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
 }
 
 static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)

@@ -1411,7 +1411,7 @@ static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
 
 static __always_inline void __raw_spin_unlock(struct raw_spinlock *lock)
 {
-	return PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
+	PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
 }
 
 #endif
Signature · 1 line
1.5.6.3.536.g61aad
#1 lore raw

[ Added cc ]

Quoted 33 lines · On Thu, 17 Jul 2008 14:22:34 -0700 Harvey Harrison <[email protected]>…

include/asm/paravirt.h:1404:2: warning: returning void-valued expression include/asm/paravirt.h:1414:2: warning: returning void-valued expression

Signed-off-by Harvey Harrison <[email protected]>

---
Appeared between next-20080716 and next-20080717

 include/asm-x86/paravirt.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-x86/paravirt.h +2 -2
index b2aba8f..27c9f22 100644
@@ -1401,7 +1401,7 @@ static inline int __raw_spin_is_contended(struct raw_spinlock *lock)
 
 static __always_inline void __raw_spin_lock(struct raw_spinlock *lock)
 {
-	return PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
+	PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
 }
 
 static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)

@@ -1411,7 +1411,7 @@ static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
 
 static __always_inline void __raw_spin_unlock(struct raw_spinlock *lock)
 {
-	return PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
+	PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
 }
 
 #endif
Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
Applied
#2 lore raw
In reply to Harvey Harrison
Quoted 2 lines · Harvey Harrison

include/asm/paravirt.h:1404:2: warning: returning void-valued expression include/asm/paravirt.h:1414:2: warning: returning void-valued expression

applied to tip/x86/paravirt-spinlocks - thanks Harvey.

Ingo