GFS2: new warnings in -next

PATCH In review Harvey Harrison 2 participants 6 messages Jul 17, 2008 – Jul 18, 2008

Subsystems (2)

Linux-next tree GFS2 file system

lore

Share & tools

lore

Harvey Harrison

author

2008-07-17 21:08 UTC #0 lore raw

Appeared in next-20080717

Quoted 4 lines

fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)

Quoted 8 lines

fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type

Cheers,

Harvey

Harvey Harrison

author

2008-07-18 17:13 UTC #1 lore raw

PATCH 1/1 gfs2: remove nameidata arg from gfs_iop_permission

Noticed by sparse

Quoted 4 lines

fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)

Quoted 8 lines

fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type

Signed-off-by Harvey Harrison <[email protected]>

---
Appeared between next-20080716 and next-20080717

 fs/gfs2/ops_inode.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

fs/gfs2/ops_inode.c +1 -2

index 1e252df..0456e2b 100644
@@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
 	return error;
 }
 
-static int gfs2_iop_permission(struct inode *inode, int mask,
-			       struct nameidata *nd)
+static int gfs2_iop_permission(struct inode *inode, int mask)
 {
 	return gfs2_permission(inode, mask);
 }

Signature · 1 line

1.5.6.3.569.ga9185

Al Viro

2008-07-18 17:23 UTC #2 lore raw

Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission

Quoted 26 lines · Harvey Harrison

Noticed by sparse
Quoted 4 lines
fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
Quoted 8 lines
fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
Signed-off-by Harvey Harrison <[email protected]>
---
Appeared between next-20080716 and next-20080717
 fs/gfs2/ops_inode.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/gfs2/ops_inode.c +0 -0
index 1e252df..0456e2b 100644

fs/gfs2/ops_inode.c int gfs2_permission(struct inode *inode, int mask) · line 921

Quoted 9 lines

fs/gfs2/ops_inode.c +1 -2

@@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
 	return error;
 }
 
-static int gfs2_iop_permission(struct inode *inode, int mask,
-			       struct nameidata *nd)
+static int gfs2_iop_permission(struct inode *inode, int mask)
 {
 	return gfs2_permission(inode, mask);
 }

Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function completely; what tree are you working with?

Harvey Harrison

author

2008-07-18 17:30 UTC #3 lore raw

Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission

Quoted 30 lines · Al Viro

Quoted 29 lines · Harvey Harrison
Noticed by sparse
Quoted 4 lines
fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
Quoted 8 lines
fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
Signed-off-by Harvey Harrison <[email protected]>
---
Appeared between next-20080716 and next-20080717
 fs/gfs2/ops_inode.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/gfs2/ops_inode.c +0 -0
index 1e252df..0456e2b 100644
@@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
 	return error;
 }
 

Quoted 9 lines

fs/gfs2/ops_inode.c int gfs2_permission(struct inode *inode, int mask) · line 921
Quoted 6 lines
fs/gfs2/ops_inode.c +1 -2
-static int gfs2_iop_permission(struct inode *inode, int mask,
-			       struct nameidata *nd)
+static int gfs2_iop_permission(struct inode *inode, int mask)
 {
 	return gfs2_permission(inode, mask);
 }
Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function completely; what tree are you working with?

next-20080717 still had it, this was a response to my e-mail from yesterday noting new sparse warnings. Hence the, appeared between...

If it's gone today, then no worries.

Harvey

Al Viro

2008-07-18 18:04 UTC #4 lore raw

Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission

Quoted 7 lines · Harvey Harrison

Quoted 2 lines
Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function completely; what tree are you working with?
next-20080717 still had it, this was a response to my e-mail from yesterday noting new sparse warnings. Hence the, appeared between...
If it's gone today, then no worries.

Joy. A mismerge, with Miklos' patch applied both in gfs2 and vfs trees, with vfs one containing a patch on top of that. Parts of the latter patch in fs/gfs2/ got dropped at merge in linux-next...

Harvey Harrison

author

2008-07-18 18:22 UTC #5 lore raw

Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission

Quoted 5 lines · Al Viro

Quoted 3 lines · Harvey Harrison
Quoted 2 lines
Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function completely; what tree are you working with?

Quoted 8 lines

Quoted 4 lines
next-20080717 still had it, this was a response to my e-mail from yesterday noting new sparse warnings. Hence the, appeared between...
If it's gone today, then no worries.
Joy. A mismerge, with Miklos' patch applied both in gfs2 and vfs trees, with vfs one containing a patch on top of that. Parts of the latter patch in fs/gfs2/ got dropped at merge in linux-next...

I noticed one in security/capability.c in next-20080718 today and sent you a patch.

That was the only new sparse warning in today's linux-next.

Harvey