Skip to contentSkip to conversation

pro_arm_davinci_watchdog_fix.patch

PATCH Egorov Evgeny 2 participants 2 messages Jul 22, 2008 – Jul 31, 2008 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

This patch fix bug of watchdog driver's write fuction which allow to prevent wdt timeout.

Source: MontaVista Software, Inc.
MR:26833
Type: Fix Bug
Disposition: Submitted to Wim van Sebroek

Description:
This patch fix bug of watchdog driver's write fuction which allow to prevent wdt timeout.

drivers/char/watchdog/davinci_wdt.c +0 -5
Index: linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
===================================================================
@@ -133,13 +133,8 @@ static ssize_t
 davinci_wdt_write(struct file *file, const char *data, size_t len,
 		  loff_t *ppos)
 {
-	/*  Can't seek (pwrite) on this device  */
-	if (ppos != &file->f_pos)
-		return -ESPIPE;
-
 	if (len)
 		wdt_service();
-
 	return len;
 }
 
#1 lore raw
Quoted 10 lines · On Tue, 22 Jul 2008 15:36:39 +0400 Egorov Evgeny <[email protected]> wrote:

This patch fix bug of watchdog driver's write fuction which allow to prevent wdt timeout.

Index: linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
===================================================================

drivers/char/watchdog/davinci_wdt.c +0 -0
@@ -133,13 +133,8 @@ static ssize_t
 davinci_wdt_write(struct file *file, const char *data, size_t len,
 		  loff_t *ppos)

drivers/char/watchdog/davinci_wdt.c static ssize_t · line 139

Quoted 10 lines
drivers/char/watchdog/davinci_wdt.c +0 -5
 {
-	/*  Can't seek (pwrite) on this device  */
-	if (ppos != &file->f_pos)
-		return -ESPIPE;
-
 	if (len)
 		wdt_service();
-
 	return len;
 }

Thanks, but 2.6.25's drivers/watchdog/davinci_wdt.c already has this fix, and we're not maintaining any kernels which are older than that.