Skip to contentSkip to conversation

drivers/isdn/hisax/telespci.c: fix warning

PATCH Superseded Michael Borisov 3 participants 3 messages Jul 26, 2008 – Jul 27, 2008 Kernel janitors

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/14 drivers/isdn/hisax/telespci.c: fix warning

This patch fixes the following compile warning:

drivers/isdn/hisax/telespci.c: In function ‘setup_telespci’:
drivers/isdn/hisax/telespci.c:303: warning: ‘pci_find_device’ is deprecated (declared at include/linux/pci.h:535)

---

(quoted diff) +0 -0

b/drivers/isdn/hisax/telespci.c
index 28b08de..9ed0862 100644

drivers/isdn/hisax/telespci.c +0 -1
@@ -300,7 +300,8 @@ setup_telespci(struct IsdnCard *card)
        if (cs->typ != ISDN_CTYPE_TELESPCI)
                return (0);
 
-       if ((dev_tel = pci_find_device (PCI_VENDOR_ID_ZORAN,

PCI_DEVICE_ID_ZORAN_36120, dev_tel))) {
+ if ((dev_tel = pci_get_device(PCI_VENDOR_ID_ZORAN,

+               PCI_DEVICE_ID_ZORAN_36120, dev_tel))) {
                if (pci_enable_device(dev_tel))
                        return(0);
                cs->irq = dev_tel->irq;
#1 lore raw

From: Michael Borisov <[email protected]>
Date: Sat, 26 Jul 2008 22:44:34 +0300

Quoted 7 lines

This patch fixes the following compile warning:

drivers/isdn/hisax/telespci.c: In function ‘setup_telespci’:
drivers/isdn/hisax/telespci.c:303: warning: ‘pci_find_device’ is deprecated (declared at include/linux/pci.h:535)

If you "get" the device, you're going to have to "put" it somewhere down the line to release the reference count.

That's why this hasn't been fixed yet, it's not such a trivial matter to convert.

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¤z¹Ş—øÚ�+h®Ïâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm

#2 lore raw
In reply to Michael Borisov
Quoted 2 lines · David Miller

That's why this hasn't been fixed yet, it's not such a trivial matter to convert.

And it should really be converted to the driver model (see Documentation/PCI/pci.txt)

I think jgarzik has a bunch of these queued up somewhere for people to test.

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."