ipwireless: fix compile failure
Subsystems (3)
James Bottomley
maintainerThere's a brown paper bag compile failure introduced by this patch
commit a01386924874c4d6d67f8a34e66f04452c2abb69
Author: David Sterba <[email protected]> Date: Mon Jul 28 16:53:32 2008 +0200
ipwireless: Preallocate received packet buffers with MRU size
Really, it can't ever have been even compile tested. It looks like the closing bracket is in the wrong place, so this is the fix.
---
drivers/char/pcmcia/ipwireless/hardware.c +1 -1
@@ -568,7 +568,7 @@ static struct ipw_rx_packet *pool_allocate(struct ipw_hardware *hw,list_del (&packet->queue); }else {const int min_capacity = -ipwireless_ppp_mru (hw->network +2 ); +ipwireless_ppp_mru (hw->network) +2 ;int new_capacity;spin_unlock_irqrestore (&hw->lock, flags);
PATCH RESEND 1/1 Build fallout from scsi merge...
Quoted 1 line · James Bottomley
There's a brown paper bag compile failure introduced by this patch
hm, while at it, i still dont see the scsi build fix below upstream. My tests were hit by it too.
Ingo
------------------->
Quoted 1 line
From
c3d4eb8e157b6e4bb0b87e921bb5743cfc6f8f25Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori <[email protected]>
Date: Mon, 28 Jul 2008 11:59:20 +0900
Subject: [PATCH] Build fallout from scsi merge...
Quoted 7 lines · On Sun, 27 Jul 2008 17:04:15 -0700 (PDT) David Miller <[email protected]>…
From allmodconfig on sparc64:
drivers/scsi/qla2xxx/qla_attr.c: In function 'qla24xx_vport_delete':drivers/scsi/qla2xxx/qla_attr.c:1184: error: implicit declaration of function 'msleep' make[3]: *** [drivers/scsi/qla2xxx/qla_attr.o] Error 1
make[3]: *** Waiting for unfinished jobs....
=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] qla2xxx: fix msleep compile error
drivers/scsi/qla2xxx/qla_attr.c: In function 'qla24xx_vport_delete':drivers/scsi/qla2xxx/qla_attr.c:1184: error: implicit declaration of function 'msleep' make[3]: *** [drivers/scsi/qla2xxx/qla_attr.o] Error 1
make[3]: *** Waiting for unfinished jobs....
--- drivers/scsi/qla2xxx/qla_attr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/scsi/qla2xxx/qla_attr.c +1 -0
@@ -8,6 +8,7 @@#include <linux/kthread.h> #include <linux/vmalloc.h> +#include <linux/delay.h> static int qla24xx_vport_disable (struct fc_vport *,bool );
James Bottomley
maintainerRe: [resend] [PATCH] Build fallout from scsi merge...
Quoted 6 lines · Ingo Molnar
Quoted 1 line · James Bottomley
There's a brown paper bag compile failure introduced by this patch
hm, while at it, i still dont see the scsi build fix below upstream. My tests were hit by it too.
It's in linux next ... I was just waiting to see if there's any more fallout.
James