Skip to contentSkip to conversation

w1: select crc16 library for ds2406

PATCH In review Arnd Bergmann 3 participants 3 messages Jun 23, 2014 W1 dallas's 1-wire bus

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 w1: select crc16 library for ds2406

commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver that uses the crc16 library, but didn't ensure that the core is there. This adds the necessary Kconfig statements, just like we have it for other w1 drivers.

Cc Scott Alfter <[email protected]>
Cc Evgeniy Polyakov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
drivers/w1/slaves/Kconfig +1 -0
index fd31d2f..cfe74d0 100644
@@ -40,6 +40,7 @@ config W1_SLAVE_DS2413
 
 config W1_SLAVE_DS2406
 	tristate "Dual Channel Addressable Switch 0x12 family support (DS2406)"
+	select CRC16
 	help
 	  Say Y or M here if you want to use a 1-wire
 	  DS2406 Dual Channel Addressable Switch.  EPROM read/write
#1 lore raw
Quoted 9 lines · Arnd Bergmann

commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver that uses the crc16 library, but didn't ensure that the core is there. This adds the necessary Kconfig statements, just like we have it for other w1 drivers.

Cc Scott Alfter <[email protected]>
Cc Evgeniy Polyakov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

Sounds OK to me...was an oversight on my part. Do I need to put together another patchfile, or can this one be combined with the one I've already sent in? As an alternative, it's in my kernel tree at
https://github.com/salfter/adafruit-raspberrypi-linux.

Scott Alfter
[email protected]

#2 lore raw
Quoted 11 lines · Scott Alfter
Quoted 9 lines · Arnd Bergmann

commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver that uses the crc16 library, but didn't ensure that the core is there. This adds the necessary Kconfig statements, just like we have it for other w1 drivers.

Cc Scott Alfter <[email protected]>
Cc Evgeniy Polyakov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 4 lines

Sounds OK to me...was an oversight on my part. Do I need to put together another patchfile, or can this one be combined with the one I've already sent in? As an alternative, it's in my kernel tree at
https://github.com/salfter/adafruit-raspberrypi-linux.

I'll take it as-is, I can't do anything with some random github tree :)

thanks,

greg k-h