fix bash job control (was: my /etc/init.d/rcS won't run)

Hi,

Marc from the previous thread pointed me in the right direction to fix this.

Attached is a patch to bash.mk so it builds correctly and can be used from busybox's init.

(To create the patch, I built bash on my linux desktop to generate a config.log. Then I went through bash's aclocal.m4 to see which options were skipped when cross compiling. Anything that didn't match up with my desktop's config.log I manually forced in bash.mk).

Thanks,

Wade

And now the actual patch :-P

-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-fix_bash_jobcontrol.patch
Type: text/x-diff
Size: 736 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20080804/542bb8bd/attachment.patch

One more note: this patch seems to be the fix for this bug:

http://bugs.busybox.net/view.php?id=1244

Wade

I tried the patch, but got the attched errors (edited for brevity) -------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: errors
Url: http://busybox.net/lists/buildroot/attachments/20080805/e1f14a7c/attachment-0001.txt

Hi,

I remember seeing those errors last week when I tried this, but I'm not seeing them now.

I must have changed something else in my config :( But I know it works now because I've done a full rebuild.

Attaching my bash config.log to see if that helps.

Wade
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config.log.bz2
Type: application/x-bzip2
Size: 22441 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20080804/fa635636/attachment-0001.bin

I think I did a make busybox-dirclean when I meant bash-dirclean

It built after I did the make bash-dirclean.

Thanks

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting a bad thing?

Brian Beattie   LFS12947 | "Honor isn't about making the right choices.
beattie at beattie-home.net | It's about dealing with the consequences."
www.beattie-home.net     | -- Midori Koto

Thanks! My init startup works with bash now.

Worked for me, although my version of buildroot is a few months old. Here's my bash link line. The one difference is that I get jobs.o instead of your nojobs.o (which seems the source of your undefined symbols).

-Marc

rm -f bash /mnt/vol1/marc/linuxtest/buildroot/build_xtensa_test_mmuhifi_b/staging_dir/usr/bin/xtensa_test_mmuhifi_b-linux-uclibc-gcc -L./builti ns -L./lib/readline -L./lib/readline -L./lib/glob -L./lib/tilde -L./lib/sh -rdynamic -g -O2 -o bash shell.o eval.o y.tab.o general.o make_cmd.o print_cmd.o dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o trap.o input.o unwind_prot.o pathexp.o sig.o test.o version.o alias.o array.o arrayfunc.o braces.o bracecomp.o bashhist.o bashline.o list.o stringlib.o locale.o findcmd.o redir.o pcomplete.o pcomplib.o syntax.o xmalloc.o
signames.o -lbuiltins -lsh -lreadline -lhistory -lcurses -lglob -ltilde -ldl
ls -l bash
-rwxr-xr-x 1 marc tensilica 2007410 Aug 4 12:47 bash
xtensa_test_mmuhifi_b-linux-size bash
text data bss dec hex filename
468064 20708 19188 507960 7c038 bash
make[1]: Leaving directory `/mnt/vol1/marc/linuxtest/buildroot/build_xtensa_test_mmuhifi_b/bash-3.2'