Skip to contentSkip to conversation

cred: add static, remove extern on function definitions

PATCH In review Harvey Harrison 3 participants 3 messages Aug 9, 2008 – Aug 10, 2008 Credentials

lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 1/1 cred: add static, remove extern on function definitions

kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?

Signed-off-by Harvey Harrison <[email protected]>

---
Introduced between next-20080729 and next-20080808

 kernel/cred.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/cred.c +2 -2
index f89c5e5..d91cb06 100644
@@ -69,7 +69,7 @@ static void put_tgcred_rcu(struct rcu_head *rcu)
 /*
  * Release a set of thread group credentials.
  */
-void put_tgcred(struct thread_group_cred *tgcred)
+static void put_tgcred(struct thread_group_cred *tgcred)
 {
 	if (atomic_dec_and_test(&tgcred->usage))
 		call_rcu(&tgcred->rcu, put_tgcred_rcu);

@@ -457,7 +457,7 @@ EXPORT_SYMBOL(override_creds);
  * Revert a temporary set of override subjective credentials to an old set,
  * discarding the override set.
  */
-extern void revert_creds(const struct cred *old)
+void revert_creds(const struct cred *old)
 {
 	const struct cred *override = current->cred;
Signature · 1 line
1.6.0.rc1.278.g9c632
#2 lore raw
Quoted 8 lines · David Howells
Quoted 4 lines · Harvey Harrison

kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?

Signed-off-by Harvey Harrison <[email protected]>
Acked-by David Howells <[email protected]>

Applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds

Signature · 2 lines
James Morris
<[email protected]>