Skip to contentSkip to conversation

PM_TRACE is no longer experimental

PATCH Pavel Machek 5 participants 7 messages Aug 14, 2008 – Aug 18, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

---
commit 710f4e9070c453e743fcfa1a6017075026c4967b
tree 7f3fe656004f2d21b6a9cbe1264f9f2236572456
parent ea977ecb4f994b0dc2e09cab3dbba87aad030d99
author Pavel <[email protected]> Thu, 14 Aug 2008 17:18:07 +0200 committer Pavel <[email protected]> Thu, 14 Aug 2008 17:18:07 +0200

 kernel/power/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/power/Kconfig +1 -1
index dcd165f..1800674 100644
@@ -36,7 +36,7 @@ config PM_VERBOSE
 
 config CAN_PM_TRACE
 	def_bool y
-	depends on PM_DEBUG && PM_SLEEP && EXPERIMENTAL
+	depends on PM_DEBUG && PM_SLEEP
 
 config PM_TRACE
 	bool
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 2 lines · On 14.08.2008 17:18 Pavel Machek wrote:

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

It might be stable, but its effect of trashing the RTC makes it unsuitable for non-experimental use. Therefore I'd prefer the dependency be kept.

Thanks,
Tilman

#2 lore raw

Hi.

Quoted 6 lines · Tilman Schmidt
Quoted 2 lines · On 14.08.2008 17:18 Pavel Machek wrote:

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

It might be stable, but its effect of trashing the RTC makes it unsuitable for non-experimental use. Therefore I'd prefer the dependency be kept.

I think you're confusing 'experimental' and 'debugging'. You certainly wouldn't want to use it routinely, but that doesn't mean it's still an experimental feature.

Regards,

Nigel

#3 lore raw
In reply to Tilman Schmidt
Quoted 6 lines · On 14.08.2008 17:18 Pavel Machek wrote:
Quoted 2 lines

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

It might be stable, but its effect of trashing the RTC makes it unsuitable for non-experimental use. Therefore I'd prefer the dependency be kept.

Given that it is enabled in both 32-bit and 64-bit defconfig, I don't think we can call it experimental.

Plus IIRC it needs command line option to thrash RTC.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw
Quoted 9 lines · Pavel Machek
Quoted 6 lines · On 14.08.2008 17:18 Pavel Machek wrote:
Quoted 2 lines

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

It might be stable, but its effect of trashing the RTC makes it unsuitable for non-experimental use. Therefore I'd prefer the dependency be kept.

Given that it is enabled in both 32-bit and 64-bit defconfig, I don't think we can call it experimental.

I agree.

Quoted 1 line

Plus IIRC it needs command line option to thrash RTC.

That's correct.

Thanks,
Rafael

#5 lore raw
Quoted 10 lines · Rafael J. Wysocki
Quoted 2 lines · Pavel Machek

Given that it is enabled in both 32-bit and 64-bit defconfig, I don't think we can call it experimental.

I agree.

Quoted 1 line

Plus IIRC it needs command line option to thrash RTC.

That's correct.

Alright, I withdraw my objection.

T.

#6 lore raw
In reply to Tilman Schmidt
Quoted 6 lines · Tilman Schmidt
Quoted 2 lines · On 14.08.2008 17:18 Pavel Machek wrote:

PM_TRACE is stable for quite long. I don't think it needs to depend on experimental.

It might be stable, but its effect of trashing the RTC makes it unsuitable for non-experimental use. Therefore I'd prefer the dependency be kept.

It only does that if you boot with command line options to enable it. Besides, CONFIG_EXPERIMENTAL was always about code maturity, not a safety net for people who don't read the descriptions.

Pavels change makes sense to me.

Dave

Signature · 1 line
http://www.codemonkey.org.uk