pvrusb2: use proper byteorder interface

PATCH In review Harvey Harrison 1 participant 1 message Aug 18, 2008 Media (V4L/DVB)

lore

Share & tools

lore

Harvey Harrison

author

2008-08-18 20:38 UTC #0 lore raw

PATCH 2/2 pvrusb2: use proper byteorder interface

___swab32 is an internal detail of the implementation.

Signed-off-by Harvey Harrison <[email protected]>

---
I really suspect this should be something like be32_to_cpu...if this code was written on an x86.

 drivers/media/video/pvrusb2/pvrusb2-hdw.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

drivers/media/video/pvrusb2/pvrusb2-hdw.c +1 -2

index f051c6a..7fa903a 100644
@@ -1314,8 +1314,7 @@ int pvr2_upload_firmware2(struct pvr2_hdw *hdw)
 		memcpy(fw_ptr, fw_entry->data + fw_done, bcnt);
 		/* Usbsnoop log shows that we must swap bytes... */
 		for (icnt = 0; icnt < bcnt/4 ; icnt++)
-			((u32 *)fw_ptr)[icnt] =
-				___swab32(((u32 *)fw_ptr)[icnt]);
+			((u32 *)fw_ptr)[icnt] = swab32(((u32 *)fw_ptr)[icnt]);
 
 		ret |= usb_bulk_msg(hdw->usb_dev, pipe, fw_ptr,bcnt,
 				    &actual_length, HZ);

Signature · 1 line

1.6.0.274.g8aacc