IPC - Do not use a negative value to re-enable msgmni automatic recomputing
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 IPC - Do not use a negative value to re-enable msgmni automatic recomputing
Resending after fixing the issues pointed out by Matt. Now applies to 2.6.26-rc8-mm1.
[PATCH 01/01]
This patch proposes an alternative to the "magical positive-versus-negative number trick" Andrew complained about last week in
http://lkml.org/lkml/2008/6/24/418.
This had been introduced with the patches that scale msgmni to the amount of lowmem. With these patches, msgmni has a registered notification routine that recomputes msgmni value upon memory add/remove or ipc namespace creation/ removal.
When msgmni is changed from user space (i.e. value written to the proc file), that notification routine is unregistered, and the way to make it registered back is to write a negative value into the proc file. This is the "magical positive-versus-negative number trick".
To fix this, a new proc file is introduced: /proc/sys/kernel/auto_msgmni. This file acts as ON/OFF for msgmni automatic recomputing.
With this patch, the process is the following:
1) kernel boots in "automatic recomputing mode" /proc/sys/kernel/msgmni contains the value that has been computed (depends on lowmem) /proc/sys/kernel/automatic_msgmni contains "1"
2) echo <val> > /proc/sys/kernel/msgmni
. sets msg_ctlmni to <val>
. de-activates automatic recomputing (i.e. if, say, some memory is added
msgmni won't be recomputed anymore)
. /proc/sys/kernel/automatic_msgmni now contains "0"
3) echo "0" > /proc/sys/kernel/automatic_msgmni
. de-activates msgmni automatic recomputing
this has the same effect as 2) except that msg_ctlmni's value stays blocked at its current value)
3) echo "1" > /proc/sys/kernel/automatic_msgmni
. recomputes msgmni's value based on the current available memory size
and number of ipc namespaces
. re-activates automatic recomputing for msgmni.
This patch applies to 2.6.26-rc8-mm1.
--- include/linux/ipc_namespace.h | 3 + ipc/ipc_sysctl.c | 72 ++++++++++++++++++++++++++++++++++-------- ipc/ipcns_notifier.c | 20 ++++++++--- 3 files changed, 76 insertions(+), 19 deletions(-)
include/linux/ipc_namespace.h +2 -1
@@ -36,6 +36,7 @@ struct ipc_namespace {int msg_ctlmni;atomic_t msg_bytes;atomic_t msg_hdrs; +int auto_msgmni;size_t shm_ctlmax;size_t shm_ctlall;
@@ -53,7 +54,7 @@ extern atomic_t nr_ipc_ns;extern int register_ipcns_notifier (struct ipc_namespace *);extern int cond_register_ipcns_notifier (struct ipc_namespace *); -extern int unregister_ipcns_notifier (struct ipc_namespace *); +extern void unregister_ipcns_notifier (struct ipc_namespace *);extern int ipcns_notify (unsigned long );#else /* CONFIG_SYSVIPC */
ipc/ipcns_notifier.c +15 -5
@@ -55,25 +55,35 @@ static int ipcns_callback(struct notifieint register_ipcns_notifier (struct ipc_namespace *ns) { +int rc; +memset (&ns->ipcns_nb,0 ,sizeof (ns->ipcns_nb)); ns->ipcns_nb.notifier_call = ipcns_callback; ns->ipcns_nb.priority =IPCNS_CALLBACK_PRI ; -return blocking_notifier_chain_register (&ipcns_chain, &ns->ipcns_nb); + rc =blocking_notifier_chain_register (&ipcns_chain, &ns->ipcns_nb); +if (!rc) + ns->auto_msgmni =1 ; +return rc; }int cond_register_ipcns_notifier (struct ipc_namespace *ns) { +int rc; +memset (&ns->ipcns_nb,0 ,sizeof (ns->ipcns_nb)); ns->ipcns_nb.notifier_call = ipcns_callback; ns->ipcns_nb.priority =IPCNS_CALLBACK_PRI ; -return blocking_notifier_chain_cond_register (&ipcns_chain, + rc =blocking_notifier_chain_cond_register (&ipcns_chain, &ns->ipcns_nb); +if (!rc) + ns->auto_msgmni =1 ; +return rc; } -int unregister_ipcns_notifier (struct ipc_namespace *ns) +void unregister_ipcns_notifier (struct ipc_namespace *ns) { -return blocking_notifier_chain_unregister (&ipcns_chain, - &ns->ipcns_nb); +blocking_notifier_chain_unregister (&ipcns_chain, &ns->ipcns_nb); + ns->auto_msgmni =0 ; }int ipcns_notify (unsigned long val)
ipc/ipc_sysctl.c +59 -13
117 lines not on this page · raw message
--
Quoted 39 lines · On Fri, 04 Jul 2008 08:37:16 +0200 [email protected] wrote:
Resending after fixing the issues pointed out by Matt. Now applies to 2.6.26-rc8-mm1.
[PATCH 01/01]
This patch proposes an alternative to the "magical positive-versus-negative number trick" Andrew complained about last week in
http://lkml.org/lkml/2008/6/24/418.This had been introduced with the patches that scale msgmni to the amount of lowmem. With these patches, msgmni has a registered notification routine that recomputes msgmni value upon memory add/remove or ipc namespace creation/ removal.
When msgmni is changed from user space (i.e. value written to the proc file), that notification routine is unregistered, and the way to make it registered back is to write a negative value into the proc file. This is the "magical positive-versus-negative number trick".
To fix this, a new proc file is introduced:
/proc/sys/kernel/auto_msgmni. This file acts as ON/OFF for msgmni automatic recomputing.With this patch, the process is the following:
1) kernel boots in "automatic recomputing mode"/proc/sys/kernel/msgmnicontains the value that has been computed (depends on lowmem)/proc/sys/kernel/automatic_msgmnicontains "1"2) echo <val> >
/proc/sys/kernel/msgmni
. setsmsg_ctlmnito <val>
. de-activates automatic recomputing (i.e. if, say, some memory is added
msgmni won't be recomputed anymore)
./proc/sys/kernel/automatic_msgmninow contains "0"3) echo "0" >
/proc/sys/kernel/automatic_msgmni
. de-activates msgmni automatic recomputing
this has the same effect as 2) except that msg_ctlmni's value stays blocked at its current value)
Quoted 5 lines
3) echo "1" >
/proc/sys/kernel/automatic_msgmni
. recomputes msgmni's value based on the current available memory size
and number of ipc namespaces
. re-activates automatic recomputing for msgmni.
Sigh. I suppose it's a bit better.
Quoted 4 lines
--- include/linux/ipc_namespace.h | 3 + ipc/ipc_sysctl.c | 72 ++++++++++++++++++++++++++++++++++-------- ipc/ipcns_notifier.c | 20 ++++++++---
Could we get this all documented for our poor users please?
Documentation/filesystems/proc.txt is probably the most appropriate place.
Quoted 54 lines · Andrew Morton
Quoted 39 lines · On Fri, 04 Jul 2008 08:37:16 +0200 [email protected] wrote:
Resending after fixing the issues pointed out by Matt. Now applies to 2.6.26-rc8-mm1.
[PATCH 01/01]
This patch proposes an alternative to the "magical positive-versus-negative number trick" Andrew complained about last week in
http://lkml.org/lkml/2008/6/24/418.This had been introduced with the patches that scale msgmni to the amount of lowmem. With these patches, msgmni has a registered notification routine that recomputes msgmni value upon memory add/remove or ipc namespace creation/ removal.
When msgmni is changed from user space (i.e. value written to the proc file), that notification routine is unregistered, and the way to make it registered back is to write a negative value into the proc file. This is the "magical positive-versus-negative number trick".
To fix this, a new proc file is introduced:
/proc/sys/kernel/auto_msgmni. This file acts as ON/OFF for msgmni automatic recomputing.With this patch, the process is the following:
1) kernel boots in "automatic recomputing mode"/proc/sys/kernel/msgmnicontains the value that has been computed (depends on lowmem)/proc/sys/kernel/automatic_msgmnicontains "1"2) echo <val> >
/proc/sys/kernel/msgmni
. setsmsg_ctlmnito <val>
. de-activates automatic recomputing (i.e. if, say, some memory is added
msgmni won't be recomputed anymore)
./proc/sys/kernel/automatic_msgmninow contains "0"3) echo "0" >
/proc/sys/kernel/automatic_msgmni
. de-activates msgmni automatic recomputing
this has the same effect as 2) except that msg_ctlmni's value stays blocked at its current value)Quoted 5 lines
3) echo "1" >
/proc/sys/kernel/automatic_msgmni
. recomputes msgmni's value based on the current available memory size
and number of ipc namespaces
. re-activates automatic recomputing for msgmni.Sigh. I suppose it's a bit better.
Quoted 4 lines
--- include/linux/ipc_namespace.h | 3 + ipc/ipc_sysctl.c | 72 ++++++++++++++++++++++++++++++++++-------- ipc/ipcns_notifier.c | 20 ++++++++---
Quoted 6 lines
Could we get this all documented for our poor users please?
Documentation/filesystems/proc.txtis probably the most appropriate place.
Sorry for answering so late, but I just came back from a looooong vacation.
Actually, I first thought of documenting this new file in proc.txt, but didn't find anything related to the ipc tunables there, that's why I finally gave up with the idea.
I'll send an update of the proc.txt as soon as possible.
Regards,
Nadia
Signature · 1 line
Nadia Derbey <[email protected]>