Skip to contentSkip to conversation

MPC83XX: Fix GPIO configuration

PATCH New Nick Spence 2 participants 3 messages Aug 23, 2008 – Aug 25, 2008

lore
Share & tools
lore

Nick Spence

author
#0 lore raw

PATCH 1/1 MPC83XX: Fix GPIO configuration

Set DAT value before DIR values to avoid creating glitches on the GPIO signals.

---
 cpu/mpc83xx/cpu_init.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
cpu/mpc83xx/cpu_init.c +2 -2
index 67c9e57..4514dbb 100644
@@ -283,12 +283,12 @@ void cpu_init_f (volatile immap_t * im)
 	im->sysconf.lblaw[7].ar = CFG_LBLAWAR7_PRELIM;
 #endif
 #ifdef CFG_GPIO1_PRELIM
-	im->gpio[0].dir = CFG_GPIO1_DIR;
 	im->gpio[0].dat = CFG_GPIO1_DAT;
+	im->gpio[0].dir = CFG_GPIO1_DIR;
 #endif
 #ifdef CFG_GPIO2_PRELIM
-	im->gpio[1].dir = CFG_GPIO2_DIR;
 	im->gpio[1].dat = CFG_GPIO2_DAT;
+	im->gpio[1].dir = CFG_GPIO2_DIR;
 #endif
 }
Signature · 1 line
1.5.2.2
#1 lore raw

PATCH 1/1 MPC83XX: Fix GPIO configuration

Quoted 3 lines · On Fri, 22 Aug 2008 23:52:50 -0700 Nick Spence <[email protected]>…

Set DAT value before DIR values to avoid creating glitches on the GPIO signals.
---

I need a sign off before I can apply this.

Kim

author
#2 lore raw

PATCH 1/1 MPC83XX: Fix GPIO configuration

Kim Phillips wrote:
On Fri, 22 Aug 2008 23:52:50 -0700

Quoted 11 lines
Quoted 1 line · Nick Spence

Set DAT value before DIR values to avoid creating glitches

on the GPIO

Quoted 2 lines

signals.
---

I need a sign off before I can apply this.

Kim

Signed-off-by Nick Spence <[email protected]>

Thanks,
Nick