Skip to contentSkip to conversation

ARM: dts: add mshc controller node for Exynos4x12 SoCs

PATCH New Thomas Abraham 5 participants 9 messages Jan 21, 2013 – Dec 20, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -0
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
 		interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
 			     <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
 	};
+
+	mshc at 12550000 {
+		compatible = "samsung,exynos4412-dw-mshc";
+		reg = <0x12550000 0x1000>;
+		interrupts = <0 77 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
 };
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

Hi Thomas,

Good to see your patch, actually I had sent similar one before but no one care my patch. And now I feel it seems to be wrong.

But I have a couple of question if I use your patch to enable MSHC controller work properly on Exynos4412.

What's the exact form of ".compatible" on board file? With your patch, MSHC is not probed at all in my board. The ".compatible" has to be 'samsung,exynos5250-dw-mshc' and it works.

I also tried '.compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc"', it probes the driver but in the function 'dw_mci_exynos_priv_init', priv->ctrl_type always becomes DW_MCI_TYPE_EXYNOS5250. Because there is a loop and returns each compatible strings in alphanumeric order whatever it is ordered in the board file.

I also tried below patch to add a compatible for Exynos4412 to 'dw_mci_exynos_match' with its specific data, and it works. What's the right direction? If I am missing something or wrong, please correct me. :)

Many thanks,
Dongjin.

@@ -184,6 +186,25 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,

        return 0;

}

+/* Exynos4412 controller specific capabilities */ +static unsigned long exynos4412_dwmmc_caps[4] = {
+ MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
+ MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,

+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+};
+
+static const struct dw_mci_drv_data exynos4412_drv_data = {
+       .caps                   = exynos4412_dwmmc_caps,
+       .init                   = dw_mci_exynos_priv_init,
+       .setup_clock            = dw_mci_exynos_setup_clock,
+       .prepare_command        = dw_mci_exynos_prepare_command,
+       .set_ios                = dw_mci_exynos_set_ios,
+       .parse_dt               = dw_mci_exynos_parse_dt,
+       .setup_bus              = dw_mci_exynos_setup_bus,
+};
+
 /* Exynos5250 controller specific capabilities */
 static unsigned long exynos5250_dwmmc_caps[4] = {
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |

@@ -204,6 +225,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
};

static const struct of_device_id dw_mci_exynos_match[] = {
+ { .compatible = "samsung,exynos4412-dw-mshc",
+ .data = &exynos4412_drv_data, },

        { .compatible = "samsung,exynos5250-dw-mshc",
                        .data = &exynos5250_drv_data, },
        {},
Quoted 38 lines · Thomas Abraham

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -1
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
                interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
                             <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
        };
+
+       mshc at 12550000 {
+               compatible = "samsung,exynos4412-dw-mshc";
+               reg = <0x12550000 0x1000>;
+               interrupts = <0 77 0>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
 };
--

1.7.5.4

#2 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

Hi Dongjin,

Quoted 19 lines · Dongjin Kim

Hi Thomas,

Good to see your patch, actually I had sent similar one before but no one care my patch. And now I feel it seems to be wrong.

But I have a couple of question if I use your patch to enable MSHC controller work properly on Exynos4412.

What's the exact form of ".compatible" on board file? With your patch, MSHC is not probed at all in my board. The ".compatible" has to be 'samsung,exynos5250-dw-mshc' and it works.

I also tried '.compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc"', it probes the driver but in the function 'dw_mci_exynos_priv_init', priv->ctrl_type always becomes DW_MCI_TYPE_EXYNOS5250. Because there is a loop and returns each compatible strings in alphanumeric order whatever it is ordered in the board file.

Quoted 4 lines

I also tried below patch to add a compatible for Exynos4412 to 'dw_mci_exynos_match' with its specific data, and it works. What's the right direction? If I am missing something or wrong, please correct me. :)

Yes, your below patch is the correct thing to do. The dt patches for dwmmc controller driver were only tested on Exynos5250 based board. So I had not added the compatible string for Exynos4412 in 'of_match_table' of the driver. Please submit the below change as a patch (minor comment below).

Quoted 6 lines

Many thanks,
Dongjin.

(quoted diff) +0 -0
@@ -184,6 +186,25 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
        return 0;

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 196

Quoted 10 lines
(quoted diff) +8 -0
 }
 
+/* Exynos4412 controller specific capabilities */
+static unsigned long exynos4412_dwmmc_caps[4] = {
+       MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
+               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+};

Since this is same as the 'exynos5250_dwmmc_caps', it can be reused for 4412 as well, avoiding duplicate copy 'exynos4412_dwmmc_caps'.

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 206

Quoted 10 lines
(quoted diff) +10 -0
+
+static const struct dw_mci_drv_data exynos4412_drv_data = {
+       .caps                   = exynos4412_dwmmc_caps,
+       .init                   = dw_mci_exynos_priv_init,
+       .setup_clock            = dw_mci_exynos_setup_clock,
+       .prepare_command        = dw_mci_exynos_prepare_command,
+       .set_ios                = dw_mci_exynos_set_ios,
+       .parse_dt               = dw_mci_exynos_parse_dt,
+       .setup_bus              = dw_mci_exynos_setup_bus,
+};

If the above change is done, 'exynos4412_drv_data ' also could be avoided.

Review static const struct dw_mci_drv_data exynos5250_drv_data = { · line 232

Quoted 13 lines
(quoted diff) +3 -0
+
 /* Exynos5250 controller specific capabilities */
 static unsigned long exynos5250_dwmmc_caps[4] = {
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
@@ -204,6 +225,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+       { .compatible = "samsung,exynos4412-dw-mshc",
+                       .data = &exynos4412_drv_data, },
        { .compatible = "samsung,exynos5250-dw-mshc",
                        .data = &exynos5250_drv_data, },
        {},

Thanks,
Thomas.

Quoted 42 lines
Quoted 38 lines · Thomas Abraham

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -1
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
                interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
                             <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
        };
+
+       mshc at 12550000 {
+               compatible = "samsung,exynos4412-dw-mshc";
+               reg = <0x12550000 0x1000>;
+               interrupts = <0 77 0>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
 };
--

1.7.5.4

#3 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

Hello Thomas,

Thank you. I will submit the change soon.

Thanks again.
Dongjin.

Quoted 125 lines · Thomas Abraham

Hi Dongjin,

Quoted 19 lines · Dongjin Kim

Hi Thomas,

Good to see your patch, actually I had sent similar one before but no one care my patch. And now I feel it seems to be wrong.

But I have a couple of question if I use your patch to enable MSHC controller work properly on Exynos4412.

What's the exact form of ".compatible" on board file? With your patch, MSHC is not probed at all in my board. The ".compatible" has to be 'samsung,exynos5250-dw-mshc' and it works.

I also tried '.compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc"', it probes the driver but in the function 'dw_mci_exynos_priv_init', priv->ctrl_type always becomes DW_MCI_TYPE_EXYNOS5250. Because there is a loop and returns each compatible strings in alphanumeric order whatever it is ordered in the board file.

Quoted 4 lines

I also tried below patch to add a compatible for Exynos4412 to 'dw_mci_exynos_match' with its specific data, and it works. What's the right direction? If I am missing something or wrong, please correct me. :)

Yes, your below patch is the correct thing to do. The dt patches for dwmmc controller driver were only tested on Exynos5250 based board. So I had not added the compatible string for Exynos4412 in 'of_match_table' of the driver. Please submit the below change as a patch (minor comment below).

Quoted 6 lines

Many thanks,
Dongjin.

(quoted diff) +0 -0
@@ -184,6 +186,25 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
        return 0;

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 196

Quoted 10 lines
(quoted diff) +8 -0
 }
 
+/* Exynos4412 controller specific capabilities */
+static unsigned long exynos4412_dwmmc_caps[4] = {
+       MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
+               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+};

Since this is same as the 'exynos5250_dwmmc_caps', it can be reused for 4412 as well, avoiding duplicate copy 'exynos4412_dwmmc_caps'.

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 206

Quoted 10 lines
(quoted diff) +10 -0
+
+static const struct dw_mci_drv_data exynos4412_drv_data = {
+       .caps                   = exynos4412_dwmmc_caps,
+       .init                   = dw_mci_exynos_priv_init,
+       .setup_clock            = dw_mci_exynos_setup_clock,
+       .prepare_command        = dw_mci_exynos_prepare_command,
+       .set_ios                = dw_mci_exynos_set_ios,
+       .parse_dt               = dw_mci_exynos_parse_dt,
+       .setup_bus              = dw_mci_exynos_setup_bus,
+};

If the above change is done, 'exynos4412_drv_data ' also could be avoided.

Review static const struct dw_mci_drv_data exynos5250_drv_data = { · line 232

Quoted 13 lines
(quoted diff) +3 -0
+
 /* Exynos5250 controller specific capabilities */
 static unsigned long exynos5250_dwmmc_caps[4] = {
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
@@ -204,6 +225,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+       { .compatible = "samsung,exynos4412-dw-mshc",
+                       .data = &exynos4412_drv_data, },
        { .compatible = "samsung,exynos5250-dw-mshc",
                        .data = &exynos5250_drv_data, },
        {},

Thanks,
Thomas.

Quoted 42 lines
Quoted 38 lines · Thomas Abraham

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -1
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
                interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
                             <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
        };
+
+       mshc at 12550000 {
+               compatible = "samsung,exynos4412-dw-mshc";
+               reg = <0x12550000 0x1000>;
+               interrupts = <0 77 0>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
 };
--

1.7.5.4

#4 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

This patch had been tested on v3.8-rc4 with ODROID-X hardware.

Quoted 134 lines · Dongjin Kim

Hello Thomas,

Thank you. I will submit the change soon.

Thanks again.
Dongjin.

Quoted 125 lines · Thomas Abraham

Hi Dongjin,

Quoted 19 lines · Dongjin Kim

Hi Thomas,

Good to see your patch, actually I had sent similar one before but no one care my patch. And now I feel it seems to be wrong.

But I have a couple of question if I use your patch to enable MSHC controller work properly on Exynos4412.

What's the exact form of ".compatible" on board file? With your patch, MSHC is not probed at all in my board. The ".compatible" has to be 'samsung,exynos5250-dw-mshc' and it works.

I also tried '.compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc"', it probes the driver but in the function 'dw_mci_exynos_priv_init', priv->ctrl_type always becomes DW_MCI_TYPE_EXYNOS5250. Because there is a loop and returns each compatible strings in alphanumeric order whatever it is ordered in the board file.

Quoted 4 lines

I also tried below patch to add a compatible for Exynos4412 to 'dw_mci_exynos_match' with its specific data, and it works. What's the right direction? If I am missing something or wrong, please correct me. :)

Yes, your below patch is the correct thing to do. The dt patches for dwmmc controller driver were only tested on Exynos5250 based board. So I had not added the compatible string for Exynos4412 in 'of_match_table' of the driver. Please submit the below change as a patch (minor comment below).

Quoted 6 lines

Many thanks,
Dongjin.

(quoted diff) +0 -0
@@ -184,6 +186,25 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
        return 0;

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 196

Quoted 10 lines
(quoted diff) +8 -0
 }
 
+/* Exynos4412 controller specific capabilities */
+static unsigned long exynos4412_dwmmc_caps[4] = {
+       MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
+               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+       MMC_CAP_CMD23,
+};

Since this is same as the 'exynos5250_dwmmc_caps', it can be reused for 4412 as well, avoiding duplicate copy 'exynos4412_dwmmc_caps'.

Review static int dw_mci_exynos_setup_bus(struct dw_mci *host, · line 206

Quoted 10 lines
(quoted diff) +10 -0
+
+static const struct dw_mci_drv_data exynos4412_drv_data = {
+       .caps                   = exynos4412_dwmmc_caps,
+       .init                   = dw_mci_exynos_priv_init,
+       .setup_clock            = dw_mci_exynos_setup_clock,
+       .prepare_command        = dw_mci_exynos_prepare_command,
+       .set_ios                = dw_mci_exynos_set_ios,
+       .parse_dt               = dw_mci_exynos_parse_dt,
+       .setup_bus              = dw_mci_exynos_setup_bus,
+};

If the above change is done, 'exynos4412_drv_data ' also could be avoided.

Review static const struct dw_mci_drv_data exynos5250_drv_data = { · line 232

Quoted 13 lines
(quoted diff) +3 -0
+
 /* Exynos5250 controller specific capabilities */
 static unsigned long exynos5250_dwmmc_caps[4] = {
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
@@ -204,6 +225,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+       { .compatible = "samsung,exynos4412-dw-mshc",
+                       .data = &exynos4412_drv_data, },
        { .compatible = "samsung,exynos5250-dw-mshc",
                        .data = &exynos5250_drv_data, },
        {},

Thanks,
Thomas.

Quoted 42 lines
Quoted 38 lines · Thomas Abraham

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -1
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
                interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
                             <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
        };
+
+       mshc at 12550000 {
+               compatible = "samsung,exynos4412-dw-mshc";
+               reg = <0x12550000 0x1000>;
+               interrupts = <0 77 0>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
 };
--

1.7.5.4

#5 lore raw

PATCH 1/1 ARM: dts: add mshc controller node for Exynos4x12 SoCs

In reply to Thomas Abraham
Quoted 7 lines · Thomas Abraham

Commit cea0f256 ("ARM: dts: Add board dts file for ODROID-X") includes a node
to describe the board level properties for mshc controller. But the mshc controller node was not added in the Exynos4x12 dtsi file which resulted in the following warning when compiling the dtb files.

Quoted 5 lines

Warning (reg_format): "reg" property in /mshc at 12550000/slot at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /mshc at 12550000/slot at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value

for

Quoted 30 lines

/mshc at 12550000/slot at 0

Fix this by adding the mshc controller node for Exynos4x12 SoCs.

---
 arch/arm/boot/dts/exynos4412.dtsi |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -1
index 78ed377..96f5b66 100644
@@ -32,4 +32,12 @@
 		interrupts = <0 57 0>, <0 0 0>, <0 0 0>, <0 0 0>,
 			     <1 12 0>, <1 12 0>, <1 12 0>, <1 12 0>;
 	};
+
+	mshc at 12550000 {
+		compatible = "samsung,exynos4412-dw-mshc";
+		reg = <0x12550000 0x1000>;
+		interrupts = <0 77 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
 };
--
Quoted 1 line

1.7.5.4

Looks good to me, applied with "Tested-by: Dongjin Kim <[email protected]>"

Thanks.

- Kukjin

#6 lore raw

PATCH 1/1 ARM: dts: add clock provider for mshc node for Exynos4412 SOC

In reply to Thomas Abraham

Clock lookup information is required as driver can manipulate clock rate properly.

---
 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +2 -0
index ec1b166..9cbe59a 100644
@@ -41,5 +41,7 @@
 		interrupts = <0 77 0>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		clocks = <&clock 301>, <&clock 149>;
+		clock-name = "biu", "ciu";
 	};
 };
Signature · 1 line
1.7.0.4
Applied
#7 lore raw

PATCH 1/1 ARM: dts: add clock provider for mshc node for Exynos4412 SOC

Quoted 13 lines · Seungwon Jeon

Clock lookup information is required as driver can manipulate clock rate properly.

---
  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +0 -0
index ec1b166..9cbe59a 100644

arch/arm/boot/dts/exynos4412.dtsi line 47

Quoted 7 lines
arch/arm/boot/dts/exynos4412.dtsi +2 -0
@@ -41,5 +41,7 @@
  		interrupts =<0 77 0>;
  		#address-cells =<1>;
  		#size-cells =<0>;
+		clocks =<&clock 301>,<&clock 149>;
+		clock-name = "biu", "ciu";
  	};
  };

Applied, thanks.

- Kukjin

#8 lore raw

PATCH 1/1 ARM: dts: add clock provider for mshc node for Exynos4412 SOC

Hi Kukjin,

Quoted 9 lines · On Saturday 21 of December 2013 05:44:24 Kukjin Kim wrote:
Quoted 8 lines · Seungwon Jeon

Clock lookup information is required as driver can manipulate clock rate properly.

---
  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 14 lines

arch/arm/boot/dts/exynos4412.dtsi line 47

Quoted 12 lines
arch/arm/boot/dts/exynos4412.dtsi +2 -0
index ec1b166..9cbe59a 100644
@@ -41,5 +41,7 @@
  		interrupts =<0 77 0>;
  		#address-cells =<1>;
  		#size-cells =<0>;
+		clocks =<&clock 301>,<&clock 149>;
+		clock-name = "biu", "ciu";
  	};
  };

Applied, thanks.

I'm afraid you should not have applied this patch. More than this is needed for correct support of DW-MSHC on Exynos 4x12 and I already posted a series doing so more than a week ago.

Please refer to this thread:
http://thread.gmane.org/gmane.linux.kernel.samsung-soc/25493

Best regards,
Tomasz