Skip to contentSkip to conversation

alsa: ac97_patch make functions static

PATCH Applied Harvey Harrison 2 participants 2 messages Aug 29, 2008 – Sep 1, 2008 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alsa: ac97_patch make functions static

Only used in ac97_codec by including ac97_patch.c directly, effectively static

Found by sparse:
sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static? sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?

---
 sound/pci/ac97/ac97_patch.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
sound/pci/ac97/ac97_patch.c +2 -2
index d0cab1d..6ce3cbe 100644
@@ -3548,7 +3548,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1617a[] = {
 	},
 };
 
-int patch_vt1617a(struct snd_ac97 * ac97)
+static int patch_vt1617a(struct snd_ac97 * ac97)
 {
 	int err = 0;
 	int val;
@@ -3764,7 +3764,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1618[] = {
 	}
 };
 
-int patch_vt1618(struct snd_ac97 *ac97)
+static int patch_vt1618(struct snd_ac97 *ac97)
 {
 	return patch_build_controls(ac97, snd_ac97_controls_vt1618,
 				    ARRAY_SIZE(snd_ac97_controls_vt1618));
Signature · 1 line
1.6.0.366.gf9ffa8
Applied
#1 lore raw

At Fri, 29 Aug 2008 13:32:00 -0700,

Quoted 8 lines · Harvey Harrison

Only used in ac97_codec by including ac97_patch.c directly, effectively static

Found by sparse:
sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static? sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?

Thanks, applied now.

Takashi

Quoted 31 lines
---
 sound/pci/ac97/ac97_patch.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
sound/pci/ac97/ac97_patch.c +2 -2
index d0cab1d..6ce3cbe 100644
@@ -3548,7 +3548,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1617a[] = {
 	},
 };
 
-int patch_vt1617a(struct snd_ac97 * ac97)
+static int patch_vt1617a(struct snd_ac97 * ac97)
 {
 	int err = 0;
 	int val;
@@ -3764,7 +3764,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1618[] = {
 	}
 };
 
-int patch_vt1618(struct snd_ac97 *ac97)
+static int patch_vt1618(struct snd_ac97 *ac97)
 {
 	return patch_build_controls(ac97, snd_ac97_controls_vt1618,
 				    ARRAY_SIZE(snd_ac97_controls_vt1618));
Signature · 1 line
1.6.0.366.gf9ffa8