Skip to contentSkip to conversation

ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

PATCH In review Bryan Wu 2 participants 3 messages Sep 2, 2008 – Sep 3, 2008 Sound

lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

From: Cliff Cai <[email protected]>

v1-v2:
- only adding this dummy function in nommu arch

---
 sound/core/pcm_native.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
sound/core/pcm_native.c +14 -0
index c49b9d9..1e88cde 100644
@@ -3391,6 +3391,14 @@ out:
 }
 #endif /* CONFIG_SND_SUPPORT_OLD_API */
 
+#ifndef CONFIG_MMU
+unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
+				      unsigned long len, unsigned long pgoff, unsigned long flags)
+{
+	return 0;
+}
+#endif
+
 /*
  *  Register section
  */
@@ -3407,6 +3415,9 @@ const struct file_operations snd_pcm_f_ops[2] = {
 		.compat_ioctl = 	snd_pcm_ioctl_compat,
 		.mmap =			snd_pcm_mmap,
 		.fasync =		snd_pcm_fasync,
+#ifndef CONFIG_MMU
+		.get_unmapped_area =	dummy_get_unmapped_area,
+#endif
 	},
 	{
 		.owner =		THIS_MODULE,
@@ -3419,5 +3430,8 @@ const struct file_operations snd_pcm_f_ops[2] = {
 		.compat_ioctl = 	snd_pcm_ioctl_compat,
 		.mmap =			snd_pcm_mmap,
 		.fasync =		snd_pcm_fasync,
+#ifndef CONFIG_MMU
+		.get_unmapped_area =	dummy_get_unmapped_area,
+#endif
 	}
 };
Signature · 1 line
1.5.6
#1 lore raw
Quoted 16 lines · Bryan Wu

From: Cliff Cai <[email protected]>

v1-v2:
- only adding this dummy function in nommu arch

---
 sound/core/pcm_native.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
sound/core/pcm_native.c +0 -0
index c49b9d9..1e88cde 100644

sound/core/pcm_native.c out: · line 3400

Quoted 10 lines
sound/core/pcm_native.c +7 -0
@@ -3391,6 +3391,14 @@ out:
 }
 #endif /* CONFIG_SND_SUPPORT_OLD_API */
 
+#ifndef CONFIG_MMU
+unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
+                                     unsigned long len, unsigned long pgoff, unsigned long flags)
+{
+       return 0;
+}
+#endif

if you had:
#else

# define dummy_get_unmapped_area NULL
#endif
then you could avoid #ifdef in the rest of the file ...
-mike
author
#2 lore raw
Quoted 30 lines · Mike Frysinger
Quoted 16 lines · Bryan Wu

From: Cliff Cai <[email protected]>

v1-v2:
- only adding this dummy function in nommu arch

---
 sound/core/pcm_native.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
sound/core/pcm_native.c +0 -0
index c49b9d9..1e88cde 100644

sound/core/pcm_native.c out: · line 3400

Quoted 10 lines
sound/core/pcm_native.c +7 -0
@@ -3391,6 +3391,14 @@ out:
 }
 #endif /* CONFIG_SND_SUPPORT_OLD_API */
 
+#ifndef CONFIG_MMU
+unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
+                                     unsigned long len, unsigned long pgoff, unsigned long flags)
+{
+       return 0;
+}
+#endif

if you had:
#else

Quoted 5 lines
# define dummy_get_unmapped_area NULL
#endif
then you could avoid #ifdef in the rest of the file ...
-mike

Right, I will refresh this patch.

-Bryan